Font size: Allow for custom font size handling #58422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for custom font size handling in font size useBlockProps
ramonjd
added
[Type] Regression
|
Size Change: +245 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b3e2eb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7706633717
|
It's pretty weird. Here's the output: /* Rendered in the browser in editor JS */
font-size: clamp(31.152px, 1.947rem + 2.484vw - 7.9488px, 55px);/* True value generated by Gutenberg */
font-size: clamp(31.152px, 1.947rem + ((1vw - 3.2px) * 2.484), 55px);I've logged the output right up to the point of the edit function in the paragraph block and I'm seeing the "true" value. Maybe the browser (Chrome, FF and Safari) are doing some pre-render calculation/optimization 🤷🏻 I'm not sure it makes a difference visually 2024-01-30.16.20.09.mp4 |
ramonjd
changed the title
Interesting! Could it be React or other processing doing any magic here? I notice the internal brackets have been removed so it feels like those calculations have been performed before the CSS string has been output, perhaps 🤔 For my own interest, I double-checked the MDN docs for clamp and it says that the current form of the clamp values we're using are valid:
So long as the computed value is the same either way, I don't think it matters personally, but it would be good to know what is causing the calculated to be flattened. Very strange! |
🤦🏻 I think we're good 😄 Looks like the browser (or React) is optimizing the calculation, which is written in long hand: (1vw - 3.2px) * 2.484 === 2.484vw - 7.9488px |
Thanks for checking @andrewserong Yeah it could be. It seems to have the math right, so I don't think there's a problem. 🤞🏻 |
andrewserong
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Great work @ramonjd, and thanks for adding the test coverage here so that we can be confident in the output! 🎉
This is testing nicely for me:
✅ In a theme with fluid set to false, the fluid output is bypassed
✅ In a theme with fluid set to true, the fluid rules are correctly output for custom font-sizes
✅ Preset font-sizes are output correctly, and this PR fixes a subtle bug with that. On trunk I see the string for the preset was being output, but with this PR the real font size value is used. On trunk I doubt we ever really saw the issue as the font-size from the classname winds up taking effect, but it's still a good bit of tidying:
| Trunk | This PR |
|---|---|
LGTM! ✨
Abstract addFilter
ramonjd
added
Backport to WP 6.7 Beta/RC
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow for custom font size handling in font size useBlockProps
TODO
Why?
To fix a regression. See: #56912 (review)
How?
Checking for the presence of a custom font size. If one exists, run it through
getTypographyFontSizeValue(), which will return either the custom value orclamp()value if the theme supports fluid typography.Testing Instructions