Add Inline comment experimental flag #60622

poojabhimani12 · 2024-04-10T06:18:10Z

What?

Introducing the "Block Comment" experiment, with added functionality accessible via this feature flag which when enabled, allows users to add comments to the selected block by clicking on "comment" icon in the toolbar dropdown.

Why?

#59445

How?

Testing Instructions

Enable the Block Comment experiment
Insert any block
Click on More dropdown from the block toolbar
Click the comment icon in the toolbar and add comment.

Screenshots or screencast

demo.webm

github-actions · 2024-04-10T06:18:24Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @akashdhawade1991, @juhibhatt19.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: akashdhawade1991, juhibhatt19.

Co-authored-by: poojabhimani12 <poojabhimani@git.wordpress.org>
Co-authored-by: MD-sunilprajapati <spmultidots@git.wordpress.org>
Co-authored-by: rishishah-multidots <rishishah@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: mtias <matveb@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-04-10T06:18:39Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @poojabhimani12! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Experimental block commenting

Try/inline block commenting

ingeniumed · 2024-05-29T15:39:00Z

The following is a summary of the discussion that was had with @ellatrix, that's being posted by me for posterity.

In order to be able to test this feature end to end, this PR would need to be updated to add the ability to save comments as well. As a result, the following will need to be be done as the next steps:

Update the PR with the data model proposed here so that it actually persists everything. That way, you can see it working end to end.
Once this PR is merged in, keep an eye on the feature to see what sort of feedback is coming. Make any changes relevant to the feedback.
After sometime, put up a PR to drop the experimental flag so that it can ship in the next WP release - ideally 6.7

Try/inline block commenting

Addressed feedback

…ltidots/gutenberg into try/inline-block-commenting

…enting Address Rest API Feedbacks

…enting comment rest api function in condition

mtias · 2024-09-09T20:30:07Z

lib/experiments-page.php

+		'gutenberg-experiments',
+		'gutenberg_experiments_section',
+		array(
+			'label' => __( 'Enable multi-user commenting on blocks', 'gutenberg' ),


This should say something about being internal or for collaborators.

We’ve made this update based on the feedback provided here: #60622 (comment).

I'm happy to defer to Matías if he has suggestions. Perhaps: "Enable collaborative commenting on blocks."?

Fix reply comment issue

poojabhimani12 · 2024-09-10T06:33:02Z

Here are the details for the split PRs:

Rest API PR - Add/rest api for block commenting #65181
Add Speech Bubble icon - Add/add block comment icon #65180
Comments supports to the block editor package - Add Inline comment experimental flag #60622

Remove comment icon

…enting update comment icon code for menu and toolbar group

Sync with trunk

poojabhimani12 · 2024-09-16T13:08:36Z

I've been looking again the code changes of this PR. My understanding is that actually most of the feature is not a "block editor" feature. Aside the "button" to trigger the addition of a comment, everything is "editor" package (so WP specific)...

So a simpler solution to what I suggested above would be to actually move all of the code from the "block-editor" package to the "editor" package instead and use Slots or Extensibility APIs to inject the "comment" button into the block menu settings.

I would still suggest trying to split the PR to smaller PRs when possible though (for instance the REST API changes)

I have moved all the code from the "block-editor" package to the "editor" package.

youknowriad · 2024-09-17T13:03:21Z

packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js

+
+								<__unstableCommentIconFill.Slot
+									fillProps={ { onClose } }
+								/>


Do we really need another slot, we already have BlockSettingsMenuControls or __unstableBlockSettingsMenuFirstItem in this menu already. Can we use one of these?

Based on feedback, we've added a new slot to display the comment icon below the "Add after" option. If we use the __unstableBlockSettingsMenuFirstItem slot, the comment icon will instead appear at the top of the menu group.

I know, how important the position is. Can it be at the top or at the end of the menu instead ?

Yes, we can position it at the top, as shown here. We can also confirm with jasmussen to ensure he's okay with this change.

@jasmussen @jameskoster

ellatrix · 2024-09-23T21:23:03Z

lib/compat/wordpress-6.7/rest-api.php

+		return $response;
+	}
+	add_filter( 'rest_prepare_comment', 'add_user_avatar_urls_in_rest_response_6_7', 10, 1 );
+}


I didn't see this in the REST API PR #65181, is it not relevant there?

We have implemented changes based on feedback from @tyxla directly in the REST API PR #65181 . For testing purposes, both files have been synced. If you'd prefer us to remove the REST API code from this PR, please let us know, and we'll handle it.

ellatrix · 2024-09-23T21:24:23Z

packages/editor/package.json

@@ -34,6 +34,7 @@
 		"@babel/runtime": "^7.16.0",
 		"@wordpress/a11y": "file:../a11y",
 		"@wordpress/api-fetch": "file:../api-fetch",
+		"@wordpress/autop": "^4.7.0",


Why do we need this? This is a sort of legacy package that should be avoided. I don't understand why it's needed.

Based on feedback, we have added this package.

…enting sync rest-api file with api PR

Add Inline comment experimental flag

200bd36

poojabhimani12 requested review from spacedmonkey and ellatrix as code owners April 10, 2024 06:18

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 10, 2024

poojabhimani12 marked this pull request as draft April 10, 2024 06:20

akashdhawade1991 and others added 9 commits May 14, 2024 10:48

Experimental block commenting

08d520f

Fix comment display issue

4cddd7b

Fix comment button text issue

4fce70c

Merge pull request #1 from akashdhawade2005/try/inline-block-commenting

ead6f64

Experimental block commenting

Merge branch 'trunk' into try/inline-block-commenting

5225f4d

Sync with trunk

89930f1

Merge pull request #2 from akashdhawade2005/try/inline-block-commenting

48ddd17

Try/inline block commenting

Update editor-settings.php

694c2ea

Update experiments-page.php

5be0043

poojabhimani12 marked this pull request as ready for review May 16, 2024 04:49

poojabhimani12 requested review from fluiddot and dcalhoun as code owners May 16, 2024 04:49

cbravobernal added the [Type] Experimental Experimental feature or API. label May 16, 2024

Fix: Broken README.md link for block library

682a21b

akashdhawade1991 and others added 4 commits May 29, 2024 22:13

Block collab

f4d866e

Address pipeline issues

768d87d

Address pipeline issues

d82ecc2

Merge pull request #3 from akashdhawade2005/try/inline-block-commenting

0cea02c

Try/inline block commenting

poojabhimani12 requested a review from ajitbohra as a code owner June 5, 2024 06:42

juhibhatt19 and others added 3 commits June 6, 2024 17:38

Added UI Design changes for Comment Popover section

871c745

Collab sidebar

82a01f4

Collab sidebar

db64f73

MD-sunilprajapati and others added 10 commits September 6, 2024 15:28

Update context for edit button

68d203e

Merge pull request #43 from MD-sunilprajapati/address-feedback

b296d2d

Addressed feedback

feedback changes

bddceeb

Merge branch 'try/inline-block-commenting' of github.com:rishishah-mu…

c5094a0

…ltidots/gutenberg into try/inline-block-commenting

feedback changes for comment rest API

a23241a

Merge pull request #44 from rishishah-multidots/try/inline-block-comm…

9548565

…enting Address Rest API Feedbacks

Merge branch 'WordPress:trunk' into try/inline-block-commenting

06e840f

comment rest api function in condition

3883a11

Merge pull request #45 from rishishah-multidots/try/inline-block-comm…

334daf2

…enting comment rest api function in condition

Merge branch 'WordPress:trunk' into try/inline-block-commenting

b028876

mtias reviewed Sep 9, 2024

View reviewed changes

MD-sunilprajapati and others added 2 commits September 10, 2024 11:46

Fix reply comment issue

cd63f6a

Merge pull request #50 from MD-sunilprajapati/fix-reply-comment-issue

9b12661

Fix reply comment issue

poojabhimani12 mentioned this pull request Sep 10, 2024

Add/rest api for block commenting #65181

Open

MD-sunilprajapati and others added 8 commits September 10, 2024 14:24

Remove comment icon

f287eff

Merge pull request #51 from MD-sunilprajapati/remove-icon

16ebd4c

Remove comment icon

update comment icon code for menu and toolbar group

7aa5508

resolve eslint errors

e55109f

revert package-lock file

f66d825

Merge pull request #59 from rishishah-multidots/try/inline-block-comm…

7ff9a79

…enting update comment icon code for menu and toolbar group

resolve trunk conflicts

d01c693

Merge pull request #60 from rishishah-multidots/sync-with-trunk

2caf2d1

Sync with trunk

youknowriad reviewed Sep 17, 2024

View reviewed changes

ellatrix reviewed Sep 23, 2024

View reviewed changes

rishishah-multidots and others added 3 commits September 24, 2024 16:12

sync rest-api file with api PR

6bda66d

sync rest-api file with api PR

64b1b31

Merge pull request #61 from rishishah-multidots/try/inline-block-comm…

31ea3b5

…enting sync rest-api file with api PR

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Inline comment experimental flag #60622

Add Inline comment experimental flag #60622

poojabhimani12 commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024

ingeniumed commented May 29, 2024

mtias Sep 9, 2024

poojabhimani12 Sep 10, 2024

jasmussen Sep 10, 2024

poojabhimani12 commented Sep 10, 2024

poojabhimani12 commented Sep 16, 2024

youknowriad Sep 17, 2024

poojabhimani12 Sep 18, 2024

youknowriad Sep 18, 2024

poojabhimani12 Sep 18, 2024

youknowriad Sep 18, 2024

ellatrix Sep 23, 2024

poojabhimani12 Sep 24, 2024

ellatrix Sep 23, 2024

poojabhimani12 Sep 24, 2024

Add Inline comment experimental flag #60622

Are you sure you want to change the base?

Add Inline comment experimental flag #60622

Conversation

poojabhimani12 commented Apr 10, 2024 • edited Loading

What?

Why?

How?

Testing Instructions

Screenshots or screencast

github-actions bot commented Apr 10, 2024 • edited Loading

Unlinked Accounts

github-actions bot commented Apr 10, 2024

ingeniumed commented May 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poojabhimani12 commented Sep 10, 2024

poojabhimani12 commented Sep 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poojabhimani12 commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading