Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Bindings: Prioritize existing placeholder over bindingsPlaceholder #65220

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Block Bindings: Prioritize existing placeholder over bindingsPlaceholder #65220

merged 11 commits into from
Sep 24, 2024

Commits on Sep 20, 2024

  1. Pass data-custom-placeholder prop to all RichText instances that are … 

    …modifying the placeholder prop
    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5863a0f View commit details
    Browse the repository at this point in the history

  2. Use placeholder if data-custom-placeholder is true

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a816522 View commit details
    Browse the repository at this point in the history

  3. Add test

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f9e53bf View commit details
    Browse the repository at this point in the history

  4. Only use placeholder if aria-label is not defined

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    394e032 View commit details
    Browse the repository at this point in the history

  5. Prioritize custom placeholder in aria-label

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4be800d View commit details
    Browse the repository at this point in the history

  6. Fix Cover block test

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e71d384 View commit details
    Browse the repository at this point in the history

  7. Revert aria-label changes

    @zaguiini @SantosGuillamot
    zaguiini authored and SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9257d80 View commit details
    Browse the repository at this point in the history

  8. Try: Read block attribute in bindings placeholder

    @SantosGuillamot
    SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fa19fc8 View commit details
    Browse the repository at this point in the history

  9. Revert changes to placeholder prop

    @SantosGuillamot
    SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    eb71d51 View commit details
    Browse the repository at this point in the history

  10. Fix after rebase

    @SantosGuillamot
    SantosGuillamot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a9da96d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Explicitly return null for empty values

    @SantosGuillamot
    SantosGuillamot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0027219 View commit details
    Browse the repository at this point in the history