Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required version in PHP. #65301

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Sep 13, 2024

What?

Updates the minimum required version in the admin notices and deactivation hooks.

Why?

To match the minimum version in the plugin header for consistency.

How?

  • Introduces a constant for the minimum required WordPress version
  • Updates the minimum version checks to use said constant
  • Introduces a unit test to ensure the plugin header and new constant match

Let me know if you'd like me to define the value elsewhere or avoid using a constant.

Testing Instructions

  1. Install a version of WordPress 6.4
  2. Visit the dashboard
  3. Ensure that the plugin deactivates and a notice is shown to the user.

Testing Instructions for Keyboard

Screenshots or screencast

@peterwilsoncc peterwilsoncc force-pushed the fix/requirement-check-to-match-header branch from 7fe8588 to fdeeefe Compare September 13, 2024 01:59
@peterwilsoncc peterwilsoncc added No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended labels Sep 13, 2024
@peterwilsoncc peterwilsoncc self-assigned this Sep 13, 2024
@peterwilsoncc peterwilsoncc marked this pull request as ready for review September 13, 2024 03:33
Copy link

github-actions bot commented Sep 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peterwilsoncc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants