Comments Pagination: Fix warning returned by comments pagination blocks #65435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
reviewed
Sep 18, 2024
| @@ -37,7 +37,7 @@ function render_block_core_comments_pagination_next( $attributes, $content, $blo | |||
| $label .= $pagination_arrow; | |||
| } | |||
|
|
|||
| $next_comments_link = get_next_comments_link( $label, $max_page, $comment_vars['paged'] ); | |||
| $next_comments_link = get_next_comments_link( $label, $max_page, $comment_vars['paged'] ?? null ); | |||
There was a problem hiding this comment.
Finally, we can use PHP 7 features everywhere. How nice!
gziolo
approved these changes
Sep 18, 2024
gziolo
changed the title
SantosGuillamot
deleted the
fix/warning-returned-by-comments-pagination-blocks
branch
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65424
Why?
It shouldn't return a warning in that scenario.
How?
I added a safety check to return null when
$comment_vars['paged']is not defined.I couldn't adapt the e2e tests because the testing instance has
WP_DEBUGset to false and doesn't show warnings.Testing Instructions