Handle zoom out when changing device preview #65444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: +20 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
LGTM!
Another thing I was wondering is whether a follow-up PR should address the reverse operation as well:
That is, whether or not to reset the device type to desktop when we enable the zoom out mode.
Currently, the zoom out toggle button doesn't reset the device type, which is why the device preview icon changes:
d35d0bac10c18bbac2aa08c79f3108b3.mp4
AhmarZaidi
reviewed
Sep 18, 2024
| @@ -44,6 +45,12 @@ export default function PreviewDropdown( { forceIsAutosaveable, disabled } ) { | |||
| }; | |||
| }, [] ); | |||
| const { setDeviceType } = useDispatch( editorStore ); | |||
| const { __unstableSetEditorMode } = useDispatch( blockEditorStore ); | |||
|
|
|||
| const handleDevicePreviewChange = ( newDeviceType ) => { | |||
There was a problem hiding this comment.
Should we add doc comment for the new function?
This is what I was thinking:
/**
* Handles the selection of a device type from preview dropdown.
*
* Turns off the zoom out mode after setting the device type.
*
* @param {string} newDeviceType The selected device type.
*/
There was a problem hiding this comment.
I think there are no clear rules about JSDoc, but this is an internal function that is not exposed, and the process it performs is just two lines.
I personally don't think JSDoc is necessary because we can see what it's doing at a glance and I feel like JSDoc is a bit over the top. 😄
andrewserong
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 20, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 0237d6e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65411
Why?
Bug fix.
How?
The device preview and zoom out toggle are two components that live in the same place in the component tree so they can be aware of the same mechanism and states of the UI. So I added a call to disable zoom out if a preview size is selected.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
zoomout-vs-device.mp4