Blocks: Change get_hooked_blocks() to returned hooked blocks grouped by relative position #5296
Conversation
…by relative position
| if ( array_key_exists( $relative_position, $hooked_block_types ) ) { | ||
| $hooked_block_types = $hooked_block_types[ $relative_position ]; | ||
| } else { | ||
| $hooked_block_types = array(); | ||
| } |
There was a problem hiding this comment.
These extra checks are probably the biggest downside of the suggested change (needed for each position; see below).
The alternative would be to make get_hooked_blocks create empty arrays for all positions, but I didn't like that option so much either; one drawback would be that we'd need to give get_hooked_blocks a list of possible relative positions (which we'd also need to update if we introduce new ones); whereas with the current approach, we can keep get_hooked_blocks ignorant of what relative positions exist, and let it create arrays for whatever it finds.
|
Uh, used the wrong remote to open the PR 🤦♂️ Will close and open one in my own fork. |
|
See the unit test diff to see how the return format has changed.
The main reason for doing is is that all existing calls of
get_hooked_blocksin production code used to need an extraarray_keyscall. This seemed beside the point.Furthermore, this allows us to remove the extra
$relative_positionargument from the function again, as the same data can now be simply fetched via array access.Trac ticket: TBD
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.