Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Webpack #2618

Open
jaclynjessup opened this issue Feb 28, 2024 · 1 comment
Open

Upgrade Webpack #2618

jaclynjessup opened this issue Feb 28, 2024 · 1 comment
Assignees
@josh-bagwell @RayRedGoose
Labels
12.x dependencies Pull requests that update a dependency file enhancement New feature or request
Milestone
12.0.0

Comments

@jaclynjessup
Copy link
Member

jaclynjessup commented Feb 28, 2024 •
edited
Loading

🚀 Feature Proposal

Upgrade webpack

Motivation

To help with dependency upgrades and allowing the possibility to upgrade to Storybook7+
@jaclynjessup jaclynjessup changed the title Upgrade Webback Upgrade Webpack Feb 29, 2024
@jaclynjessup jaclynjessup added blocked This issue is waiting for one or more issues to be closed/resolved. on hold PR is on hold until further notice labels Apr 5, 2024
@josh-bagwell josh-bagwell self-assigned this Jul 23, 2024
@josh-bagwell josh-bagwell added 12.x enhancement New feature or request dependencies Pull requests that update a dependency file and removed blocked This issue is waiting for one or more issues to be closed/resolved. on hold PR is on hold until further notice labels Jul 23, 2024
@josh-bagwell josh-bagwell added this to the 12.0.0 milestone Jul 23, 2024
@jaclynjessup
Copy link
Member Author

remaining work to be completed
IN SCOPE

  • address failing tests now that we've move over to the component test runner

  • globally ignore landmark tests

  • aria-label on icon button

  • address any issues on the Canvas Site

OUT OF SCOPE (to be addressed at a later date)

  • address our GH actions that build storybook before cypress but we dont need this anymore with using component test runner;
    so lets build storybook and run cypress in parallel

  • a few styles on the storybook

@mannycarrera4 mannycarrera4 mentioned this issue Aug 27, 2024
Merged
alanbsmith pushed a commit that referenced this issue Aug 28, 2024
@RayRedGoose @NicholasBoll @josh-bagwell
chore!: Upgrade Storybook and Webpack (#2674)
f1f40e7 
Fixes: #2618 

We've upgraded Storybook, Webpack, Typescript and Cypress.

[category:Infrastructure]

Release Note:
- In Storybook, each component now has a "Docs" page. This is dedicated to documentation of the component and has examples as it did before. 
- We now use the Cypress Component runner and not e2e.
- Codemod formatting has been updated with a dependency update and docs have been added to reflect the formatting issue. 

The following have been upgraded:
- Storybook 7
- Webpack 5 
- Typescript 4.9
- Cypress 13

### BREAKING CHANGES
Codemods formatting have been updated and users will need to format their files after the codemod has been used.

Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Co-authored-by: @josh-bagwell <josh.bagwell@workday.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-bagwell josh-bagwell

@RayRedGoose RayRedGoose

Labels
12.x dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Canvas Kit
Status: ✅ Done
Milestone
12.0.0
Development

No branches or pull requests
3 participants
@jaclynjessup @josh-bagwell @RayRedGoose