Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemIcon doesn't allow inhering of backgroundColor or backgroundHover #2930

Closed
mannycarrera4 opened this issue Sep 18, 2024 · 0 comments · Fixed by #2932
Closed

SystemIcon doesn't allow inhering of backgroundColor or backgroundHover #2930

mannycarrera4 opened this issue Sep 18, 2024 · 0 comments · Fixed by #2932
Labels
10.x bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

mannycarrera4 commented Sep 18, 2024 •
edited
Loading

🐛 Bug Report

In SystemIcon, we were defining a default value for the backgroundColor and backgroundHover css variables.

This "blocks" styles from being inherited from a parent element. We should remove these default values to allow users to style those variables as they wish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.x bug Something isn't working
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow inherit background color on system icon mannycarrera4/canvas-kit
1 participant
@mannycarrera4