-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Radio compound component #1944
feat: Add new Radio compound component #1944
Conversation
1 flaky tests on run #5942 ↗︎
Details:
cypress/integration/Autocomplete.spec.ts • 1 flaky testThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
We should test this to make sure this works with formfield in preview |
We received a question about uncontrolled form fields - this would apply to autofill issues as well. For example, here's how to do a radio group using React Hook Form since that library uses |
modules/react/_examples/stories/examples/SidePanelWithNavigation.tsx
Outdated
Show resolved
Hide resolved
modules/react/action-bar/stories/visual-testing/stories_action-bar.tsx
Outdated
Show resolved
Hide resolved
modules/react/action-bar/stories/visual-testing/stories_action-bar.tsx
Outdated
Show resolved
Hide resolved
ref={ref} | ||
{...elemProps} | ||
/> | ||
<span id="ck-radio-check"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the addition that makes sure everything is styled in firefox and chrome. TIL you can't add pseudo elements like ::before or ::after to non container elements like inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work on this @mani11 and @mannycarrera4!
Summary
Fixes: #1196
Adds a new compound Radio component to the Preview package.
Release Category
Components
Release Note
We've created a new Radio compound component in the Preview package. This component matches our pattern of providing access to lower-level elements and allows for more flexibility.
Checklist
ready for review
has been added to PRFor the Reviewer