Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update toast padding to account for long text and no close icon #2266

Closed

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Jun 22, 2023

Summary

When Toast has no close icon, text will go all the way to the edge. Adding padding to the Toast.Body adds enough spacing so that text doesn't go to the edge.

Release Category

Components


Checklist

  • MDX documentation adheres to Canvas Kit's standard MDX template
  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4 mannycarrera4 changed the title fix: Update toast message padding fix: Update toast padding to account for long text and no close icon Jun 22, 2023
@mannycarrera4 mannycarrera4 deleted the mc-fix-toast-message branch June 22, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant