fix: Support marginTop and marginBottom on ListBox #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasBoll
commented
Jul 26, 2024
Comment on lines
+95
to
+96
| marginTop={marginTop ?? marginY} | ||
| marginBottom={marginBottom ?? marginY} |
There was a problem hiding this comment.
Using ?? instead of || to support 0 which is a falsy value.
Passing run #7497 ↗︎
Details:
Review all test suite changes for PR #2844 ↗︎ |
|||||||||||||||
mannycarrera4
approved these changes
Jul 26, 2024
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds correct support for
marginTopandmarginBottomonListBoxandMenu.Listcomponents.Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Testing Manually
Changing the
marginTopormarginBottomofListBoxexamples orMenu.Listexamples.Screenshots or GIFs (if applicable)