Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge support into master #2861

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Commits on Aug 5, 2024

  1. fix(combobox): Use correct state for aria-selected (#2849)

    Fixes 2860.  `aria-selected` for combobox menu items. The cursor was used to determine `aria-selected` instead of the selected item. This changes the visuals of the selected vs focus state, but that issue is covered in #2828.
    
    [category:Components]
    
    Release Note:
    This change fixes `aria-selected` in `Combobox.Menu.Item` components, but this does change the visuals of what is considered "selected". If you have any visual tests that have a screenshot of a selected state, the visual regression will have to be updated. The same is true for DOM-based snapshot tests. `aria-selected="true"` will now be added when an item is selected and not just when the virtual cursor is on the item. If your snapshot captures this DOM state, the snapshot will have to be updated.
    NicholasBoll committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    55a9d18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    419f977 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f2567e View commit details
    Browse the repository at this point in the history