Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge prerelease/minor into prerelease/major #2876

Merged

Conversation

alanbsmith
Copy link
Member

This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:

  • Merge conflicts that cannot be automatically resolved
  • A merge resulted in check failures
    • Lint or type errors
    • Test failures
    • Unexpected visual changes
      The pull request should inform you of merge conflicts before you start if any.
  1. Run the following commands in your terminal. If this succeeds, skip step 2. The last command will run a script that tries to merge and resolve conflicts automatically.
    git branch -D merge/prerelease/minor-into-prerelease/major || true
    git fetch upstream
    git checkout --track upstream/merge/prerelease/minor-into-prerelease/major
    git pull upstream merge/prerelease/minor-into-prerelease/major -f
    git pull upstream prerelease/minor
    node utils/forward-merge.js
    
  2. If the previous step succeeded, skip to step 4.
  3. Resolve conflicts manually. Then run the following.
    git add .
    git commit -m "chore: Merge prerelease/minor into prerelease/major"
    
  4. Push the merge commit back to the pull request
    git push upstream merge/prerelease/minor-into-prerelease/major
    

If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the merge strategy instead of the squash strategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:

git commit --amend --no-edit

You must then force-push the branch and the CI will rerun verification.
Use the automerge label like normal and the CI will pick the correct merge strategy.

NicholasBoll and others added 30 commits July 29, 2024 10:58
Adds correct support for `marginTop` and `marginBottom` on `ListBox` and `Menu.List` components.

[category:Components]
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Fixes 2860.  `aria-selected` for combobox menu items. The cursor was used to determine `aria-selected` instead of the selected item. This changes the visuals of the selected vs focus state, but that issue is covered in #2828.

[category:Components]

Release Note:
This change fixes `aria-selected` in `Combobox.Menu.Item` components, but this does change the visuals of what is considered "selected". If you have any visual tests that have a screenshot of a selected state, the visual regression will have to be updated. The same is true for DOM-based snapshot tests. `aria-selected="true"` will now be added when an item is selected and not just when the virtual cursor is on the item. If your snapshot captures this DOM state, the snapshot will have to be updated.
Fixes: #2458

[category:Components]

Co-authored-by: Thu Nguyen <thu.nguyen@workday.com>
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Fixes: #2853
Set `aria-modal` to false to provide better accessibility in Modals that might have a popup like a Select.

[category:Accessibility]

Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com>
Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Resolves: #2864

[category:Components]

Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com>
Redirect the `PopupModel.state.targetRef` to the user input element instead of the hidden server input element. Tests were added to specify this behavior.

Fixes: #2868

[category:Components]
Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.4.

[category:Dependencies]

Co-authored-by: @dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Fixes: #2873

[category:Components]

Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
dependabot bot and others added 7 commits August 20, 2024 15:38
@alanbsmith alanbsmith merged commit e249801 into prerelease/major Aug 21, 2024
19 of 20 checks passed
@alanbsmith alanbsmith deleted the merge/prerelease/minor-into-prerelease/major branch August 21, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants