-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge prerelease/minor into prerelease/major #2876
Merged
alanbsmith
merged 37 commits into
prerelease/major
from
merge/prerelease/minor-into-prerelease/major
Aug 21, 2024
Merged
chore: Merge prerelease/minor into prerelease/major #2876
alanbsmith
merged 37 commits into
prerelease/major
from
merge/prerelease/minor-into-prerelease/major
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds correct support for `marginTop` and `marginBottom` on `ListBox` and `Menu.List` components. [category:Components]
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Fixes 2860. `aria-selected` for combobox menu items. The cursor was used to determine `aria-selected` instead of the selected item. This changes the visuals of the selected vs focus state, but that issue is covered in #2828. [category:Components] Release Note: This change fixes `aria-selected` in `Combobox.Menu.Item` components, but this does change the visuals of what is considered "selected". If you have any visual tests that have a screenshot of a selected state, the visual regression will have to be updated. The same is true for DOM-based snapshot tests. `aria-selected="true"` will now be added when an item is selected and not just when the virtual cursor is on the item. If your snapshot captures this DOM state, the snapshot will have to be updated.
Fixes: #2458 [category:Components] Co-authored-by: Thu Nguyen <thu.nguyen@workday.com>
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
Fixes: #2853 Set `aria-modal` to false to provide better accessibility in Modals that might have a popup like a Select. [category:Accessibility] Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com> Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Fixes: #2827 [category:Components]
Resolves: #2864 [category:Components] Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com>
Redirect the `PopupModel.state.targetRef` to the user input element instead of the hidden server input element. Tests were added to specify this behavior. Fixes: #2868 [category:Components]
Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.4. [category:Dependencies] Co-authored-by: @dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com> Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Fixes: #2873 [category:Components] Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7. [category:Dependencies] Co-authored-by: @dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com> Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
mannycarrera4
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:
The pull request should inform you of merge conflicts before you start if any.
If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the
merge
strategy instead of thesquash
strategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:You must then force-push the branch and the CI will rerun verification.
Use the
automerge
label like normal and the CI will pick the correct merge strategy.