Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Dart Sass #97

Open
diktomat opened this issue Jun 14, 2022 · 1 comment
Open

Switch to Dart Sass #97

diktomat opened this issue Jun 14, 2022 · 1 comment
Labels
type: 👷internal Improvement to workflows, internal complexity, maintainability

Comments

@diktomat
Copy link

diktomat commented Jun 14, 2022

node-sass package is deprecated and currently won't even build with Node 18 (support coming). They recommend switching to Dart Sass / the sass NPM package, which is a purely JS implementation.

As this currently hinders even building BudgetBudget, I think it'd be wise to follow this recommendation, node-sass will probably always be slower to support new versions and probably EOL some time in the future.

By the way: Have you lost interest in this project? The last activity being in November and features I want missing was the reason I cloned and tried building this in the first time, to see if my limited JS skills are enough to get myself familiarized with the code and start doing stuff myself..

@Xiphe
Copy link
Owner

Xiphe commented Jun 14, 2022

Hey @d12bb thanks for reporting this!

Folly agree that we should use sass instead of node-sass!

Regarding the project itself a bunch of things are coming together, you motivated me to write them down here: #98

@Xiphe Xiphe added the type: 👷internal Improvement to workflows, internal complexity, maintainability label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 👷internal Improvement to workflows, internal complexity, maintainability
Projects
None yet
Development

No branches or pull requests

2 participants