Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to announce maintenance or news on main page #10

Closed
SlavomirMazurPantheon opened this issue Dec 13, 2022 · 3 comments · Fixed by #15
Closed

Add possibility to announce maintenance or news on main page #10

SlavomirMazurPantheon opened this issue Dec 13, 2022 · 3 comments · Fixed by #15
Assignees
Labels
enhancement New feature or request Priority: Medium

Comments

@SlavomirMazurPantheon
Copy link
Contributor

Add functionality which will display information about planned maintenance at the top of the YANG Catalog.
Content of this message should be loaded from backend - new endpoint might be needed OR it can be fetched from some JSON file.
This component can be also used to display some news, like new release for example so different types of notifications can be displayed (info, warning).

@evyncke
Copy link

evyncke commented Dec 15, 2022

And don't forget to allow the removal of the news

@dmytro-kyrychenko
Copy link
Contributor

Hi, @evyncke.
image
Our current implementation for those notifications looks like this, and it shows on every page of the website. Which could be the problem, because even after dismissing it on previous page, you will get the same notification on the next page. We could solve this by using cookies on website, but we don't use them currently, so this will make things much more complicated. Alternative approach, we can show this maintenance message only on home page (for each reload notification will be shown again, but only for home.html)

So, what do you think? Should we stick to showing it only on home?

@SlavomirMazurPantheon SlavomirMazurPantheon linked a pull request Jan 17, 2023 that will close this issue
@dmytro-kyrychenko
Copy link
Contributor

Hi, @evyncke. So what do you think about my previous comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants