Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'ratified' check-box on the main search page #13

Closed
evyncke opened this issue Dec 16, 2022 · 7 comments · Fixed by #14
Closed

Add a 'ratified' check-box on the main search page #13

evyncke opened this issue Dec 16, 2022 · 7 comments · Fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@evyncke
Copy link

evyncke commented Dec 16, 2022

As it appears that some users' (like @mcr) intention is to search only for ratified modules, a check-box 'Ratified' (default off/false) should appear in the main search page (next to 'only latest revs') and of course the search itself should take this setting into account.

@bclaise

@evyncke evyncke added the enhancement New feature or request label Dec 16, 2022
@rjsparks
Copy link

is ratified a concept that's defined somewhere? Is it the best word to use on the UI?

@mcr
Copy link

mcr commented Dec 16, 2022

is ratified a concept that's defined somewhere? Is it the best word to use on the UI?

It's not exactly the word I would have picked, but it actually works for me.
I just wanted the default to be to be search RFCs only. If there were further results, one could highlight that.
Saying, "Standards Action" might be more correct, and you could refer to 8126, but I dunno.

@evyncke
Copy link
Author

evyncke commented Dec 18, 2022

Or should we say "Include drafts" and of course reversing the meaning with a default being checked/true ?

@SlavomirMazurPantheon
Copy link
Contributor

Hello all,

thank you for your input - so what you agreed on is:

  • UI: new checkbox with a label Include drafts that will be un-checked by default.
  • Search engine: Return only the results from the RFCs unless Include drafts is checked by user - then return also from drafts.

image

Regards,
Slavomír Mazúr

@evyncke
Copy link
Author

evyncke commented Dec 19, 2022

@SlavomirMazurPantheon you are correct EXCEPT that the default should be 'include drafts'

@SlavomirMazurPantheon
Copy link
Contributor

Okay, thank you @evyncke

@richardzilincikPantheon
Copy link
Contributor

@SlavomirMazurPantheon @evyncke
I think having a 'ratified' checkbox as originally suggested would make more sense. Modules published by organizations other than the IETF are neither ratified, nor would they be published in drafts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants