Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not invalidate invite on auto AFK kick #3005

Open
jae1911 opened this issue Sep 25, 2024 · 1 comment
Open

Do not invalidate invite on auto AFK kick #3005

jae1911 opened this issue Sep 25, 2024 · 1 comment
Labels
enhancement Suggested addition of a new feature. triaged This issue has been assessed

Comments

@jae1911
Copy link

jae1911 commented Sep 25, 2024

Describe the bug?

When being kicked out of a session via the auto AFK kick, the invite to said session will be invalidated.

To Reproduce

  1. Open a private session (server/client)
  2. Invite player
  3. Set AFK timer to 1 minute
  4. Switch to other session
  5. Get kicked out
  6. Try to join with the invite
  7. Observe that the invite has been invalidated

Expected behavior

The invite shouldn't be invalidated.

Screenshots

Video: https://youtu.be/5rAEHh_Ytvw

Resonite Version Number

Beta 2024.9.16.1105

What Platforms does this occur on?

Windows, Linux

What headset if any do you use?

Quest Pro, Desktop

Log Files

Server:
TETHYS - 2024.9.16.1105 - 2024-09-25 22_00_30.log

Client:
TETHYS - 2024.9.16.1105 - 2024-09-25 21_58_01.log

Additional Context

This is especially annoying when setting up an event and that some hosts or moderators are kicked out with no possibility of coming back (said hosts and moderators not having access to the headless console to issue another invite, having a role that gets kicked out, or the world used for the event not allowing the administrator role to be granted).

Reporters

U-j4 | j4.lc (Discord)

@jae1911 jae1911 added the bug Something isn't working as intended. label Sep 25, 2024
@shiftyscales
Copy link
Collaborator

This would be a great quality of life change. I believe at present this happens because there is nothing distinguishing the auto-kick functionality from the kick button itself in the UI- for users that are kicked manually- it makes sense to revoke access to the session- not as much usually for away kicks.

As you highlighted- when possible- users marked as admin should be excluded from the AFK auto-kick, but it may also be worthwhile to have a mechanism, e.g. in the headless config to specify a list of users to be immune to away kicking directly.

@shiftyscales shiftyscales added enhancement Suggested addition of a new feature. and removed bug Something isn't working as intended. labels Sep 26, 2024
@shiftyscales shiftyscales removed their assignment Sep 26, 2024
@shiftyscales shiftyscales added the triaged This issue has been assessed label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggested addition of a new feature. triaged This issue has been assessed
Projects
None yet
Development

No branches or pull requests

2 participants