Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for getmininginfo RPC call #5468

Closed
Tracked by #5234
mpguerra opened this issue Oct 24, 2022 · 5 comments · Fixed by #5808
Closed
Tracked by #5234

Add basic support for getmininginfo RPC call #5468

mpguerra opened this issue Oct 24, 2022 · 5 comments · Fixed by #5808
Assignees
Labels
A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Oct 24, 2022

Motivation

We want to support the RPCs used by mining pools.

https://zcash.github.io/rpc/getmininginfo.html

Tasks

s-nomp uses the networkhashps field for statistics:

This might need a new state request to calculate the network hash rate from recent blocks.

Other mining pools have told us they use the chain field to detect mainnet or testnet.

We can skip the other fields for now.

Related Work

We should probably do this at the same time as:

@teor2345 teor2345 added P-Low ❄️ A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features labels Oct 25, 2022
@mpguerra
Copy link
Contributor Author

@teor2345
Copy link
Collaborator

I'd like to know what fields we're implementing first, before I estimate this RPC.

@mpguerra
Copy link
Contributor Author

I'd like to know what fields we're implementing first, before I estimate this RPC.

Looking at this again I've decided to remove from the sprint until I can do some more research on it. FWIW I think we'd start with just the fields that we know are used by mining pools, e.g the network hash rate

@teor2345
Copy link
Collaborator

@mpguerra I've updated the ticket with the two fields we know are currently used by mining pools

@mpguerra
Copy link
Contributor Author

@mpguerra I've updated the ticket with the two fields we know are currently used by mining pools

Are you able to estimate this now based on the above 2 fields?

@arya2 arya2 changed the title Add support for getmininginfo RPC call Add basic support for getmininginfo RPC call Dec 8, 2022
@mergify mergify bot closed this as completed in #5808 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants