Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupted Nameplate Castbar Not Showing #24

Open
Adox01 opened this issue Jan 28, 2024 · 12 comments
Open

Interrupted Nameplate Castbar Not Showing #24

Adox01 opened this issue Jan 28, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@Adox01
Copy link

Adox01 commented Jan 28, 2024

Like title says, after an enemy player or npc fails a cast or you succesfully interrupt a cast, it won't show anything below nameplate even if the option Time to Hold is set up.
It only shows when HD Nameplates option is disabled but you lose the ability to see non target castbars.

HD nameplates enabled:
Animation
HD nameplates disabled:
Animation1

@Zidras Zidras added the bug Something isn't working label Jan 28, 2024
@Zidras
Copy link
Owner

Zidras commented Feb 11, 2024

Bug confirmed but ZNP will need refactoring to address this problem

Zidras added a commit that referenced this issue Mar 27, 2024
@Adox01
Copy link
Author

Adox01 commented Mar 28, 2024

Thanks Zidras, I tested this few hours ago and it worked like it supposed to be. However, after playing a bg, I noticed that the interrupt castbar was showing on enemy players even if they werent casting anything, I mean it even was showing on warriors (maybe you are already aware of it since you wrote "Fix events not passing into Update_CastBar", but idk if it is connected with the thing I described)

@Zidras
Copy link
Owner

Zidras commented Mar 28, 2024

Thanks Zidras, I tested this few hours ago and it worked like it supposed to be. However, after playing a bg, I noticed that the interrupt castbar was showing on enemy players even if they werent casting anything, I mean it even was showing on warriors (maybe you are already aware of it since you wrote "Fix events not passing into Update_CastBar", but idk if it is connected with the thing I described)

Was it showing spell icons that those warriors had? And can you confirm you use aw?

@Adox01
Copy link
Author

Adox01 commented Mar 28, 2024

Uh, I don't really remember seeing any icons, ill play a bg later and share the footage. And no, i use loriendal's client

@Zidras
Copy link
Owner

Zidras commented Mar 28, 2024

I think running transcriptor would also help me try to see which events are fired.
Having a repro scenario would be ideal.
But indeed my implementation is half-assed

@Adox01
Copy link
Author

Adox01 commented Mar 29, 2024

Hi, sorry for late response, I just played a few bgs and the bug I described didnt happen anymore, Maybe at that moment I was bugged and just needed a reload, my bad. I also played a lot of arenas and everything was working fine. I did record and used transcriptor just in case.
The only thing I noticed is that the interrupted castbar isnt showing on enemy npcs (I did reload/relog to make sure)

@Zidras
Copy link
Owner

Zidras commented Apr 2, 2024

Wow_JfY27rGV36.mp4

@Adox01 , enemy npc works fine for me

@Adox01
Copy link
Author

Adox01 commented Apr 2, 2024

Hmm, thats weird. I was leveling a rogue and when I kicked a npc cast it didnt show the failed castbar. I'll test again with my shaman on rdf and will post the footage.

@Adox01
Copy link
Author

Adox01 commented Apr 2, 2024

As seen in the video, some enemy npc shows the failed cast bar and some not. I also did FoS just to found out I wasnt recording lol, but the same thing happened.

Transcriptor file:
Transcriptor.txt

2024-04-02.18-19-24.mp4

@Zidras
Copy link
Owner

Zidras commented Apr 4, 2024

As seen in the video, some enemy npc shows the failed cast bar and some not. I also did FoS just to found out I wasnt recording lol, but the same thing happened.

Transcriptor file: Transcriptor.txt

2024-04-02.18-19-24.mp4

I don't know why I thought you used Awesome wotlk.
YOu will have to validate for me one or two timestamps of the transcriptor log where the problem happened, but I suspect it matched the times where the nameplate had no unit whatsoever, so the castbar disappears as soon as blizzard castbar also disappears from the nameplate. it wouldnt ever have event attached to it, PZ client or not - you can test it.
Edit: just rewatched the video, first example you had, nameplate was target, so my theory does not apply here. Im back to the drawing board

@Zidras
Copy link
Owner

Zidras commented Apr 4, 2024

and I think I will add CLEU handler, since SPELL_INTERRUPT better depicts whether it is an interrupt or failed

@Adox01
Copy link
Author

Adox01 commented Apr 5, 2024

I don't know if it helps but in my video when the failed castbar isn't visible on the nameplates, it appears on the target unitframe at the bottom right corner. However, when the failed castbar is displayed on the nameplates, it doesn't show on the unitframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants