Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid top-of-the-file # type: ignore statement #159

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Feb 25, 2024

On mypy for PyPy, this causes a [syntax] error: https://github.com/pypa/setuptools/actions/runs/8040607909/job/21958905599?pr=4192#step:9:1517

On regular mypy this causes [attr-defined] trying to import from fastjsonschema_validations (in setuptools, the exact error was: error: Module "setuptools.config._validate_pyproject.fastjsonschema_validations" has no attribute "validate" [attr-defined])

Both happen even if the file/folder is excluded (because it is imported)

On mypy for PyPy, this causes a `[syntax]` error: https://github.com/pypa/setuptools/actions/runs/8040607909/job/21958905599?pr=4192#step:9:1517 **even if the file is excluded** (because it is imported)

On regular mypy this causes `error: Module "validate_pyproject.fastjsonschema_validations" has no attribute "validate"  [attr-defined]` (in setuptools, the exact error was: `error: Module "setuptools.config._validate_pyproject.fastjsonschema_validations" has no attribute "validate"  [attr-defined]`
@abravalheri abravalheri merged commit ab59195 into abravalheri:main Feb 27, 2024
29 checks passed
@abravalheri
Copy link
Owner

Thank you very much @Avasam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants