Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UNO R4 WIFI software serial #151

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Add support for UNO R4 WIFI software serial #151

merged 3 commits into from
Aug 20, 2023

Conversation

hobobandy
Copy link
Contributor

Adds proper condition check for UNO R4 WIFI board to enable software serial.

Fixes #150

@ladyada
Copy link
Member

ladyada commented Aug 20, 2023

hiya! thanks so much for submitting a PR! we can review & merge PRs once they have passed continuous integration (CI). that means that code compiles cleanly for all tested platforms, is clang formatted so we maintain the same text formatting for all new code, and is doxygen documented.
if your code isnt passing, check the CI output (click on the red X next to the PR to scroll through the log and find where the error is

here is a tutorial on doxygen: https://learn.adafruit.com/the-well-automated-arduino-library/doxygen

and clang-format: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

and overall how to contribute PRs to libraries: https://learn.adafruit.com/contribute-to-arduino-with-git-and-github

once you get that green checkmark that indicates CI has passed, please comment reply to this post so we know its time for another review (we may not get notified on CI pass and miss that its time to look!)

@hobobandy
Copy link
Contributor Author

Corrected the Clang formatting, cheers!

@ladyada ladyada merged commit 0db82b2 into adafruit:master Aug 20, 2023
1 check passed
@ladyada
Copy link
Member

ladyada commented Aug 20, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNO R4 WiFi support quirks
2 participants