Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_showEndOfPage button - how should it work? #202

Open
danielghost opened this issue Oct 10, 2023 · 0 comments
Open

_showEndOfPage button - how should it work? #202

danielghost opened this issue Oct 10, 2023 · 0 comments

Comments

@danielghost
Copy link
Contributor

If enabled to allow forward navigation between pages, the button will not appear if the last block is optional. It also won't appear if _onChildren: false. Should this appear regardless when enabled, to allow this type of navigation?

See other related issues:

What is the intended behaviour of the button as it will only appear whilst the model is incomplete, so can't be used for navigation when returning to previously completed content?

Should it be enabled by default as prior to https://github.com/adaptlearning/adapt-contrib-trickle/releases/tag/v5.1.1 it wasn't an option, but will now be enabled for all content that gets recompiled from this version, unless the last block is optional? If adaptlearning/adapt-contrib-core#448 is fixed, would it make sense to change this default to false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Response
Development

No branches or pull requests

1 participant