Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make The Definition Of Services More Flexible #52

Closed
marcalwestf opened this issue Mar 2, 2024 · 0 comments · Fixed by #60
Closed

Make The Definition Of Services More Flexible #52

marcalwestf opened this issue Mar 2, 2024 · 0 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@marcalwestf
Copy link
Contributor

marcalwestf commented Mar 2, 2024

The idea of this issue is to define a needed service only once and to call it separately when needed.

Motivation
As of now, there are six docker compose files:

  • docker-compose.yml
  • docker-compose-auth.yml
  • docker-compose-cache.yml
  • docker-compose-develop.yml
  • docker-compose-storage.yml
  • docker-compose-vue.yml

In every one of these docker compose files, the required services are defined.
In very seldom cases, a service is called with different parameters.
Mostly, the exact same service is used in different docker compose files.
This means, if one of these services needs a change, it has to be done in every docker compose file, which is prone to errors.
For example, it can be changed in one docker compose file, but left out in anther, leaving the project inconsistent.

If implemented correctly, the service definition would be unified and the possibility of combining services increased.

Solution Suggested
The solution put forward in this issue aims at defining every required service only once in a docker compose file.
Examples of the new docker compose files:

  • adempiere_site-service.yml
  • postgresql-service.yml
  • adempiere_zk-service.yml
  • adempiere_grpc_server-service_standard.yml
  • adempiere_grpc_server-service_cache.yml
  • etc.

Volume and network definitions must be also considered.

Then, when calling docker compose to execute with the command
start-all.sh -d [auth, cache, develop, storage, vue, default]
the script start-all.sh would execute docker compose as follows:
docker compose -f <file1.yml> -f <file2.yml> -f <file3.yml> ... -f <file n.yml> up -d

Similar measures would take place when shutting down all services in script stop-all .sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant