Drag and drop a photo from browser causes an error

[ktaki]

Action layers.addLayers failed: base element not found

Open Adobe Stock site in a browser. Drag and drop a photo onto a canvas.

[iwehrman]

Probably happens for all images from browsers?

[ktaki]

Yes, that is the case. Dragging any image from browsers on to canvas does.

[iwehrman]

Hmm, I can't repro on Mac pgdev.1054 at 86ccaf6. Did you observe this on Mac or Win?

[ktaki]

I tried with the Mac pgdev 1060 at 86ccaf6. It is and has been easy to repro for me. @chadrolfs Can you try it? Just drag any image from a browser to a canvas.

[chadrolfs]

yep, piece of 🍰, I can repro very easily

[iwehrman]

I still can't repro, I guess it's a timing issue. Maybe some other engineer can try to repro? @DivyaPrabhakar?

[iwehrman]

@Volfied can you repro this?

[baaygun]

I can repro, given that base element is not found error is coming from PS, I'll take a look.

[baaygun]

Trick is to open a new document.

[baaygun]

I believe the problem is dragging an image to canvas acts as a paste operation, and we get the "drag" event before Photoshop had the time to update it's own document.

https://jira.corp.adobe.com/browse/PS-1370

[iwehrman]

Kicking this out of the milestone because we're blocked, but adding the Ship Blocker label.

[iwehrman]

Over to @ktaki to verify.

[ktaki]

No, it did not fix the issue. Do we want to double the delay? It seems to me, this will not result in any bad state afterwards. What would happen if we leave it as is?

[iwehrman]

Back to @shaoshing. Maybe the timeout wasn't long enough?

[iwehrman]

In theory the UI should reset itself after the unhandled error. I prefer not to rely on that though...

[shaoshing]

@iwehrman @ktaki It turns out that the error has nothing to do with time delay. I've explains the actual cause in my PR #3797, and it only happens when dropping image from browser to an empty artboard.

Here's how to reproduce the bug:
1 create a new document
2 drag any image from browser to the art board
3 error base element not found

Same operation works if the artboard is not empty:
1 create a new document
2 draw a rectangular on the artboard
3 drag any image from browser to the art board

[iwehrman]

OK, let's try it again! FBNC to @ktaki.

[ktaki]

Verified the fix.