Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Export non-artboard doc does nothing #3710

Closed
placegraphichere opened this issue Feb 16, 2016 · 8 comments
Closed

Export non-artboard doc does nothing #3710

placegraphichere opened this issue Feb 16, 2016 · 8 comments

Comments

@placegraphichere
Copy link
Contributor

Using the Export panel on a non-artboard document (JPG for example) will allow the Export button to be clicked, a file path chosen, but nothing happens.

  • Open JPG
  • File -> Export…
  • Export
  • Choose location
  • Nothing is saved
  • Expected: the file should be saved as-is (1x PNG default export). I think we should just allow this workflow. Similar to Can't export background layers #2309 allowing the addition of an asset by clicking "+".
@iwehrman
Copy link
Contributor

Is this a known limitation, @mcilroyc? Or is this a bug? I think I vaguely remember discussing this with you, but it's hazy...

@mcilroyc
Copy link
Contributor

well this is two-fer. 1) It is a known limitation but surely solvable. 2) In general, the Export modal window should not allow clicking the export button when there are no configured+selected assets.

This is assigned to the right person. I foresee a batch of export work in the near future.

@ktaki
Copy link
Contributor

ktaki commented Feb 23, 2016

@mcilroyc: Have you changed anything in this area? I can open a jpg file, add an asset, and export it as png with current master. Am I missing something here?

@chadrolfs
Copy link
Contributor

Following the steps above (no asset in the export panel in the UI under Effects), opening the Export dialog from File menu or title bar icon, will have no assets in the dialog and you CAN click the Export button at the bottom right of the dialog and select a folder to export but nothing gets exported. According to Cory's comment above, you shouldn't be able to click the Export button.

@placegraphichere
Copy link
Contributor Author

There is an aspect of "it should just work" to these issues. I'd expect to be able to export at any time. so perhaps we should think about it that we should actually not disable the export modal button, but allow them to get something exported instead.

Artboards auto populate with 1x in the export panel, so perhaps the same logic should be applied to non-artboard docs.

@mcilroyc
Copy link
Contributor

@placegraphichere I agree it should just work. I'm a little worried that the current UI would still be confusing though. Should a "blank" export dialog (with no configured exports) always just magically export a 1x document-level image?
ss

We currently have no real treatment of document-level exports in the modal window. Maybe Adding something (even a simple "export document" checkbox) to make it clear that something will happen when clicking Export. Just spit ballin

@iwehrman
Copy link
Contributor

iwehrman commented Mar 7, 2016

FBNC to @ktaki.

@ktaki
Copy link
Contributor

ktaki commented Mar 7, 2016

Confirmed the disabled Export button. I would complain the button is still as shiny as it was enabled, but I will accept it as a temporary solution.

@ktaki ktaki closed this as completed Mar 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants