From 691d40d1659d6aaac81f4037e11c243341181b80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ekrem=20Do=C4=9Fan?= Date: Thu, 18 Apr 2024 13:37:08 +0200 Subject: [PATCH] fix: make targetselector null safe (#156) --- src/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/index.js b/src/index.js index 6b3309b..e434e90 100644 --- a/src/index.js +++ b/src/index.js @@ -24,6 +24,7 @@ const getTargetValue = (element) => element.getAttribute('data-rum-target') || e || element.currentSrc || element.getAttribute('src') || element.dataset.action || element.action; const targetselector = (element) => { + if (!element) return undefined; let value = getTargetValue(element); if (!value && element.tagName !== 'A' && element.closest('a')) { value = getTargetValue(element.closest('a')); @@ -117,8 +118,8 @@ function addCWVTracking() { data.cwv[measurement.name] = measurement.value; if (measurement.name === 'LCP' && measurement.entries.length > 0) { const { element } = measurement.entries.pop(); - data.target = sampleRUM.targetselector(element); - data.source = sampleRUM.sourceselector(element) || element.outerHTML.slice(0, 30); + data.target = targetselector(element); + data.source = sourceselector(element) || element.outerHTML.slice(0, 30); } sampleRUM('cwv', data); };