Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorGatherMaskFoldingTest fails for s390x and riscv jdk 23 #5620

Open
jiekang opened this issue Sep 17, 2024 · 12 comments
Open

VectorGatherMaskFoldingTest fails for s390x and riscv jdk 23 #5620

jiekang opened this issue Sep 17, 2024 · 12 comments
Assignees

Comments

@jiekang
Copy link
Contributor

jiekang commented Sep 17, 2024

Logs:

[2024-09-16T17:39:11.476Z] Caused by: java.lang.RuntimeException: assertNotEquals: expected [1] to not equal [1]
[2024-09-16T17:39:11.476Z] 	at jdk.test.lib.Asserts.fail(Asserts.java:691)
[2024-09-16T17:39:11.476Z] 	at jdk.test.lib.Asserts.assertNotEquals(Asserts.java:451)
[2024-09-16T17:39:11.476Z] 	at jdk.test.lib.Asserts.assertNotEquals(Asserts.java:435)
[2024-09-16T17:39:11.476Z] 	at compiler.vectorapi.VectorGatherMaskFoldingTest.testTwoLongVectorLoadGatherMaskedNotEqualMask(VectorGatherMaskFoldingTest.java:227)
[2024-09-16T17:39:11.476Z] 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
[2024-09-16T17:39:11.476Z] 	... 7 more

From:
https://ci.adoptium.net/job/Grinder/10882/consoleText

@jiekang
Copy link
Contributor Author

jiekang commented Sep 17, 2024

The test is newly introduced in 23+ via:
https://bugs.openjdk.org/browse/JDK-8325520

The test is known to fail when maximum vector bits is 64:
https://bugs.openjdk.org/browse/JDK-8333248

Though the comment specifically mentions aarch64 and risc-v, it may be that it applies to s390x as well. The test has been fixed but the code was not backported to 23 yet.

@jiekang
Copy link
Contributor Author

jiekang commented Sep 17, 2024

Maybe we can check what the vector bits setting is for s390x and then consider excluding this test.

@jiekang
Copy link
Contributor Author

jiekang commented Sep 17, 2024

Or apply the patch to 23 and run the test. Not sure what will take the least amount of work/effort though...

@jiekang
Copy link
Contributor Author

jiekang commented Sep 18, 2024

Could also try other vendor releases for s390x to see if the test failed

@sophia-guo
Copy link
Contributor

I guess only openj9 support s390x

@Haroon-Khel
Copy link
Contributor

I applied the changes in adoptium/jdk@9b0a5c5 and the test passes on s390x

@jiekang
Copy link
Contributor Author

jiekang commented Sep 18, 2024

I would vote to ignore this test result for the release then.

@smlambert
Copy link
Contributor

Yes, and in fact, excluding this testcase in master using https://bugs.openjdk.org/browse/JDK-8333248 as the link in the ProblemList entry and cherrypick to October's release branch v1.0.4-release would be appropriate.

@jiekang
Copy link
Contributor Author

jiekang commented Sep 18, 2024

I will submit an exclude for the master branch and then coordinate with someone to cherry pick it.

@jiekang jiekang changed the title VectorGatherMaskFoldingTest fails for s390x jdk 23 VectorGatherMaskFoldingTest fails for s390x and riscv jdk 23 Sep 19, 2024
@jiekang
Copy link
Contributor Author

jiekang commented Sep 19, 2024

The test is also failing for the same reason on riscv. Updating this issue to track that and will also add it to the excludes.

@jiekang
Copy link
Contributor Author

jiekang commented Sep 19, 2024

Sorry for missing that in the initial PRs

@jiekang
Copy link
Contributor Author

jiekang commented Oct 7, 2024

This should be fixed in 23.0.2, coming out on 2025-01-21, so the exclusion can be removed after 23.0.1 is released on 2024-10-15.

Wonder if there's a remind me feature I can use for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants