bpo-1635741: _ast uses PyModule_AddObjectRef() (pythonGH-23146)

Replace PyModule_AddObject() with PyModule_AddObjectRef() in the _ast module (Python-ast.c).
adorilson · Mar 11, 2021 · d804003 · d804003
1 parent 6c41dfc
commit d804003
Show file tree

Hide file tree

Showing 2 changed files with 117 additions and 220 deletions.
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -1115,10 +1115,9 @@ def visitModule(self, mod):
         self.emit('if (state == NULL) {', 1)
         self.emit('return -1;', 2)
         self.emit('}', 1)
-        self.emit('if (PyModule_AddObject(m, "AST", state->AST_type) < 0) {', 1)
+        self.emit('if (PyModule_AddObjectRef(m, "AST", state->AST_type) < 0) {', 1)
         self.emit('return -1;', 2)
         self.emit('}', 1)
-        self.emit('Py_INCREF(state->AST_type);', 1)
         self.emit('if (PyModule_AddIntMacro(m, PyCF_ALLOW_TOP_LEVEL_AWAIT) < 0) {', 1)
         self.emit("return -1;", 2)
         self.emit('}', 1)
@@ -1166,11 +1165,10 @@ def visitConstructor(self, cons, name):
         self.addObj(cons.name)
 
     def addObj(self, name):
-        self.emit("if (PyModule_AddObject(m, \"%s\", "
+        self.emit("if (PyModule_AddObjectRef(m, \"%s\", "
                   "state->%s_type) < 0) {" % (name, name), 1)
         self.emit("return -1;", 2)
         self.emit('}', 1)
-        self.emit("Py_INCREF(state->%s_type);" % name, 1)
 
 
 class StaticVisitor(PickleVisitor):