From 1a9ad9be92d053bccb17d1c652bd2bb4ecd09c55 Mon Sep 17 00:00:00 2001 From: Emily Date: Tue, 9 Jul 2024 10:11:48 +0100 Subject: [PATCH] nodejs: disable JS test suite on Darwin This was recently enabled in #313982. It seems to be much too flaky on Darwin currently, especially x86; see: * * * * Disable these tests on macOS for now as the broken Node.js package is holding up a lot of builds. Fixes: b26563aae2a1fce011ac52e28ff23a460866e82f (cherry picked from commit d25d9b6a2dc90773039864bbf66c3229b6227cde) --- pkgs/development/web/nodejs/nodejs.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix index 7f6b41b791a6b84..105c4df4c9054eb 100644 --- a/pkgs/development/web/nodejs/nodejs.nix +++ b/pkgs/development/web/nodejs/nodejs.nix @@ -146,7 +146,7 @@ let "build-node-api-tests" "tooltest" "cctest" - ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin || lib.versionAtLeast version "20") [ + ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [ # There are some test failures on macOS before v20 that are not worth the # time to debug for a version that would be eventually removed in less # than a year (Node.js 18 will be EOL at 2025-04-30). Note that these @@ -158,7 +158,7 @@ let checkFlags = [ # Do not create __pycache__ when running tests. "PYTHONDONTWRITEBYTECODE=1" - ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin || lib.versionAtLeast version "20") [ + ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [ "FLAKY_TESTS=skip" # Skip some tests that are not passing in this context "CI_SKIP_TESTS=${lib.concatStringsSep "," ([