diff --git a/pybop/parameters/parameter_set.py b/pybop/parameters/parameter_set.py index 946d05ba..8a99b8b2 100644 --- a/pybop/parameters/parameter_set.py +++ b/pybop/parameters/parameter_set.py @@ -152,4 +152,10 @@ def pybamm(cls, name): pybamm.ParameterValues A PyBaMM parameter set corresponding to the provided name. """ + + msg = f"Parameter set '{name}' is not a valid PyBaMM parameter set. Available parameter sets are: {list(pybamm.parameter_sets)}" + + if name not in list(pybamm.parameter_sets): + raise ValueError(msg) + return pybamm.ParameterValues(name).copy() diff --git a/tests/unit/test_parameter_sets.py b/tests/unit/test_parameter_sets.py index fc9356d2..39d29d41 100644 --- a/tests/unit/test_parameter_sets.py +++ b/tests/unit/test_parameter_sets.py @@ -10,7 +10,7 @@ class TestParameterSets: @pytest.mark.unit def test_parameter_set(self): - # Tests parameter set creation + # Tests parameter set creation and validation with pytest.raises(ValueError): pybop.ParameterSet.pybamm("sChen2010s")