From 937aea4874a9bca3cb10ed915165300a7db0da3f Mon Sep 17 00:00:00 2001
From: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Date: Wed, 14 Feb 2024 18:40:07 +0530
Subject: [PATCH] #123 moving forward with PyBaMM parameter set check

Coverage is already up for this, this is just for PyBaMM 23.5
---
 pybop/parameters/parameter_set.py | 6 ++++++
 tests/unit/test_parameter_sets.py | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/pybop/parameters/parameter_set.py b/pybop/parameters/parameter_set.py
index 946d05ba..8a99b8b2 100644
--- a/pybop/parameters/parameter_set.py
+++ b/pybop/parameters/parameter_set.py
@@ -152,4 +152,10 @@ def pybamm(cls, name):
         pybamm.ParameterValues
             A PyBaMM parameter set corresponding to the provided name.
         """
+
+        msg = f"Parameter set '{name}' is not a valid PyBaMM parameter set. Available parameter sets are: {list(pybamm.parameter_sets)}"
+
+        if name not in list(pybamm.parameter_sets):
+            raise ValueError(msg)
+
         return pybamm.ParameterValues(name).copy()
diff --git a/tests/unit/test_parameter_sets.py b/tests/unit/test_parameter_sets.py
index fc9356d2..39d29d41 100644
--- a/tests/unit/test_parameter_sets.py
+++ b/tests/unit/test_parameter_sets.py
@@ -10,7 +10,7 @@ class TestParameterSets:
 
     @pytest.mark.unit
     def test_parameter_set(self):
-        # Tests parameter set creation
+        # Tests parameter set creation and validation
         with pytest.raises(ValueError):
             pybop.ParameterSet.pybamm("sChen2010s")