-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI #16
Comments
It passed the tests as you can see in https://travis-ci.org/ahmetb/go-httpbin/builds/210435220 |
This test succeeds with go 1.7.5 and fails with 1.8. The test is actually wrong; it sets three cookies, deletes two, then checks to see if all three remain. |
We don't just check if all 3 exists. We check that 2 are unset (to empty value), 1 is modified but all 3 are present. Since it worked this way with go1.7 just fine, I've reason to believe that either the CookieJar implementation or the http.Client's way of dealing with cookies has changed. |
For a cookie defined like this: Go 1.7 produce the following string: While Go 1.9 produce the following string: This is due to the following fix golang/go@d86a6ef So now in 1.9 you have a real deletion of the cookie thanks to the expiration time that is correctly set. |
Please enable Travis CI to prevent regressions like the current one in 2af00d7:
The text was updated successfully, but these errors were encountered: