Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports into relevant functions and branches #154

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Nov 6, 2020

The imports of aiida_optimade and requests have been moved into the relevant functions and branches.

aiida_optimade is used to retrieve the __version__ if --patch is used when updating the version.
Only if --patch is passed will aiida_optimade be imported.

requests is only used when updating the optimade package version.

@CasperWA CasperWA added CI Continuous Integration (through GitHub Actions) github_actions Pull requests that update Github_actions code labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #154 into develop will increase coverage by 0.44%.
The diff coverage is 92.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    90.15%   90.59%   +0.44%     
===========================================
  Files           28       28              
  Lines         1056     1095      +39     
===========================================
+ Hits           952      992      +40     
+ Misses         104      103       -1     
Flag Coverage Δ
pytest 90.59% <92.64%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_optimade/cli/cmd_calc.py 84.48% <88.00%> (+5.75%) ⬆️
aiida_optimade/entry_collections.py 92.67% <90.90%> (-0.23%) ⬇️
aiida_optimade/cli/cmd_init.py 95.74% <96.00%> (+4.56%) ⬆️
aiida_optimade/common/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ae34f...e1c832b. Read the comment docs.

@CasperWA CasperWA merged commit f550587 into develop Nov 6, 2020
@CasperWA CasperWA deleted the fix-imports-in-tasks branch November 6, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration (through GitHub Actions) github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant