Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only 1 retrieval query for similar requests #191

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Use only 1 retrieval query for similar requests #191

merged 2 commits into from
Jan 17, 2021

Commits on Jan 15, 2021

  1. Use only 1 retrieval query for similar requests 

    Add tests - update accordingly:
No 'limit' special condition in `count()` method.
`None` is not the same as the default `page_limit` value, since the
underlying `_find()` method doesn't use the default `page_limit`, but
rather simply sets limit to `None`.

Testing standard page_offset as well as standard use of page_limit and
also whether the max page_limit set in the configuration file is
respected.

Check how many times QueryBuilder is reported to be called in different
scenarios.

Also, add test similar to `test_count_offset` and `test_count_limit` to
test filters during count.
    @CasperWA
    CasperWA committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    19d45ed View commit details
    Browse the repository at this point in the history

  2. Set fetch-depth to 2 for the sake of codecov

    @CasperWA
    CasperWA committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    2b97e37 View commit details
    Browse the repository at this point in the history