Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #402

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Update dependencies #402

merged 3 commits into from
Nov 24, 2022

Conversation

CasperWA
Copy link
Collaborator

Update dependencies

Automatically created PR from ci/dependabot-updates.
It should be automagically merged into main upon CI success.

For more information see the "Dependabot updates" workflow.

dependabot bot and others added 3 commits November 23, 2022 17:36
* Update aiida-core requirement from ~=2.0.4 to ~=2.1.2

Updates the requirements on [aiida-core](https://github.com/aiidateam/aiida-core) to permit the latest version.
- [Release notes](https://github.com/aiidateam/aiida-core/releases)
- [Changelog](https://github.com/aiidateam/aiida-core/blob/main/CHANGELOG.md)
- [Commits](aiidateam/aiida-core@v2.0.4...v2.1.2)

---
updated-dependencies:
- dependency-name: aiida-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update AiiDA/OPTIMADE

* Use `core.psql_dos` instead of `psql_dos`

* Only use `core.` for setting the backend

* Collect CI env vars for pytest job

* Fix setting up PostrgreSQL DB in pytest CI job

* Remove `core.` from docker-used AiiDA profile

* Use VerdiCommandGroup for CLI

* Do not load profile by default and expose value

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: The AiiDA Team <developers@aiida.net>
Co-authored-by: Casper Welzel Andersen <casper.w.andersen@sintef.no>
* Update uvicorn requirement from ~=0.18.3 to ~=0.20.0

Updates the requirements on [uvicorn](https://github.com/encode/uvicorn) to permit the latest version.
- [Release notes](https://github.com/encode/uvicorn/releases)
- [Changelog](https://github.com/encode/uvicorn/blob/master/CHANGELOG.md)
- [Commits](encode/uvicorn@0.18.3...0.20.0)

---
updated-dependencies:
- dependency-name: uvicorn
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Remove using `debug` for uvicorn.run()

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <casper.w.andersen@sintef.no>
@CasperWA CasperWA added CI Continuous Integration (through GitHub Actions) dependencies Pull requests that update a dependency file labels Nov 24, 2022
@CasperWA CasperWA enabled auto-merge (squash) November 24, 2022 08:55
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 92.99% // Head: 93.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2090505) compared to base (5552f66).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #402      +/-   ##
===========================================
+ Coverage    92.99%   93.00%   +0.01%     
===========================================
  Files           31       31              
  Lines         1341     1343       +2     
===========================================
+ Hits          1247     1249       +2     
  Misses          94       94              
Flag Coverage Δ
aiida 89.35% <94.11%> (+0.01%) ⬆️
mongo 79.44% <88.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_optimade/cli/cmd_run.py 70.58% <75.00%> (+0.89%) ⬆️
aiida_optimade/cli/cmd_aiida_optimade.py 100.00% <100.00%> (ø)
aiida_optimade/cli/cmd_calc.py 83.87% <100.00%> (ø)
aiida_optimade/cli/cmd_init.py 99.20% <100.00%> (ø)
aiida_optimade/cli/utils.py 75.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CasperWA CasperWA requested a review from unkcpz November 24, 2022 09:38
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CasperWA thanks! The psql_dos -> core.psql_dos and the CLI are two essential changes that slightly breaks backward compatibility as I know and you all addressed, then I think it is all fine. Could you also set AIIDA_WARN_v3=1 to see if a deprecated API is used?

@unkcpz
Copy link
Member

unkcpz commented Nov 24, 2022

Also, the py3.10 test always failed from the last migration to 2.0. I turn it off since I thought it failed randomly, but it keeps on appearing, I assume it is related to some issue? Do you have any clue?

@CasperWA
Copy link
Collaborator Author

Also, the py3.10 test always failed from the last migration to 2.0. I turn it off since I thought it failed randomly, but it keeps on appearing, I assume it is related to some issue? Do you have any clue?

I do not have a clear clue, but the tests that are failing are perhaps quite fragile. They are depending on some subprocesses and such, and may therefore break more easily when changing Python version. I'll have to investigate further, you are also welcome. At least an issue should be made on it to follow up.

@CasperWA
Copy link
Collaborator Author

@CasperWA thanks! The psql_dos -> core.psql_dos and the CLI are two essential changes that slightly breaks backward compatibility as I know and you all addressed, then I think it is all fine. Could you also set AIIDA_WARN_v3=1 to see if a deprecated API is used?

I'm no sure what this is. Where should I set it? As an environment variable when running the pytest system?

And indeed, this is slightly backwards compatible. How was it you set up the compatibility table previously? Is this something you could perhaps add to to this PR. Or even better, create a new PR for after this one has been merged, before we then immediately afterwards create a new AiiDA-OPTIMADE release?

@unkcpz
Copy link
Member

unkcpz commented Nov 24, 2022

I'm no sure what this is. Where should I set it? As an environment variable when running the pytest system?

Yes, as an environment variable by export AIIDA_WARN_v3=1 should work I think.

Or even better, create a new PR for after this one has been merged, before we then immediately afterwards create a new AiiDA-OPTIMADE release?

No problem, I'll check and create another PR for it.

@CasperWA CasperWA merged commit 619cc5a into develop Nov 24, 2022
@CasperWA CasperWA deleted the ci/update-dependencies branch November 24, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration (through GitHub Actions) dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants