Redirect special OpenAPI endpoints for custom base URLs #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect all non-major version prefix URLs to major-version prefix URLs for the special OpenAPI docs endpoints: - docs_url: /extensions/docs - redoc_url: /extensions/redoc - openapi_url: /extensions/openapi.json
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
+ Coverage 69.34% 69.75% +0.41%
===========================================
Files 15 16 +1
Lines 809 830 +21
===========================================
+ Hits 561 579 +18
- Misses 248 251 +3
Continue to review full report at Codecov.
|
CasperWA
added a commit
to CasperWA/aiida-optimade
that referenced
this pull request
May 4, 2020
Removed several test files that are not relevant for aiida-optimade. Updated transformer tests to be applicable with AiidaTransformer. Added an update of package version to invoke task for /tests/test_config.json. Note: Keeping test_middleware.py for now, since a new middleware may be added in aiidateam#72.
CasperWA
added a commit
to CasperWA/aiida-optimade
that referenced
this pull request
May 4, 2020
Removed several test files that are not relevant for aiida-optimade. Updated transformer tests to be applicable with AiidaTransformer. Added an update of package version to invoke task for /tests/test_config.json. Note: Keeping test_middleware.py for now, since a new middleware may be added in aiidateam#72.
CasperWA
added a commit
to CasperWA/aiida-optimade
that referenced
this pull request
Jun 2, 2020
Removed several test files that are not relevant for aiida-optimade. Updated transformer tests to be applicable with AiidaTransformer. Added an update of package version to invoke task for /tests/test_config.json. Note: Keeping test_middleware.py for now, since a new middleware may be added in aiidateam#72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Redirect all non-major version prefix URLs to major-version prefix URLs
for the special OpenAPI docs endpoints:
Note: There are not tests added for this, since it would require a restructuring of the testing, since it would best be tested with an actual running server, i.e., not using the
TestClient.In any case, another PR is underway to update the tests significantly. Tests for this should/could be added at that point.