Use /links router directly from optimade-python-tools #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also means reusing the `MongoCollection`. The data is stored in `aiida_optimade/data/links.json`. Mongomock is used as the "backend" for this endpoint.
Codecov Report
@@ Coverage Diff @@
## develop #86 +/- ##
===========================================
+ Coverage 73.47% 74.12% +0.65%
===========================================
Files 18 19 +1
Lines 837 862 +25
===========================================
+ Hits 615 639 +24
- Misses 222 223 +1
Continue to review full report at Codecov.
|
CasperWA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
This also means reusing the
MongoCollection.The data is stored in
aiida_optimade/data/links.json.Mongomock is used as the "backend" for this endpoint.
Note: This update will not work until optimade-python-tools has released a new version that includes the updated
LinksResourceschema.