How to use cleanly atoms in aiohttp.server ?

[ludovic-gasc]

Hi,

I'm using aiohttp.server and self.log_access() in a daemon for a customer, I need to log user agent.

By default, in aiohttp.server, user agent log is enabled via "%(a)s": https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/server.py#L29

But, to show this piece of information, atoms() needs an environ variable: https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/helpers.py#L240

By default in aiohttp.server, environ is None: https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/server.py#L300
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/server.py#L330

What's the good practice to generate environ variable ?
Generate myself ? It isn't clear for me what it means.
Or maybe, we could change a little bit the code to use directly content in message variable ?
I can make a PR if it's ok for you.

[fafhrd91]

Yes, let's modify this code. Initially I used that code only with wsgi server

[fafhrd91]

PR would be cool!

[ludovic-gasc]

Ok, I will make a PR.
I prefer to discuss before PR, to avoid to waste my time with a rejected PR.

[fafhrd91]

I think main question where to add support for atoms. It could be server level or web.py level. I'd prefer aiohttp.web

@GMLudo are you planing to use aiohttp.web ?

[ludovic-gasc]

It's planned, but waiting that aiohttp.web officially released and do his diseases with some users.
Nevertheless, for this specific question, I prefer to keep that in aiohttp.server.
I see Web for a high level API (router, application. ..) but for me, atoms is necessary in low level. Almost everybody that uses aiohttp as server needs that.

[fafhrd91]

access logging added to aiohttp.web d46679c

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.