Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use upstr with CIMultiDict #244

Closed
fafhrd91 opened this issue Jan 14, 2015 · 5 comments
Closed

Cannot use upstr with CIMultiDict #244

fafhrd91 opened this issue Jan 14, 2015 · 5 comments
Assignees
Labels

Comments

@fafhrd91
Copy link
Member

Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/mock.py", line 1136, in patched
return func(_args, *_keywargs)
File "/Users/nikolay/dev/account-api/venv/src/aiohttp/tests/test_web_response.py", line 176, in test_compression
headers=CIMultiDict({hdrs.ACCEPT_ENCODING: 'gzip, deflate'}))
File "aiohttp/_multidict.pyx", line 200, in aiohttp._multidict.MultiDict.init (aiohttp/_multidict.c:5126)
self._extend(args, kwargs, self.class.name, 1)
File "aiohttp/_multidict.pyx", line 213, in aiohttp._multidict.MultiDict._extend (aiohttp/_multidict.c:5399)
key, value = item
nose.proxy.TypeError: Expected str, got upstr

@asvetlov
Copy link
Member

Did you added a new test to the suite?
If yes please make a branch with failing test.

It's unlikely that we have the different behavior on Linux and MacOSX.

I suspect I've missed some edge case in multidict implementation.

@fafhrd91
Copy link
Member Author

added "multidict-error" branch

@fafhrd91 fafhrd91 mentioned this issue Jan 14, 2015
@asvetlov
Copy link
Member

Got it, working on fix

@asvetlov
Copy link
Member

Fixed

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants