Azure pipeline support for arm64 using qemu #519
Conversation
.azure-pipelines/ci.yml
Outdated
| @@ -20,3 +20,4 @@ variables: | |||
| stages: | |||
| - template: stage-lint.yml | |||
| - template: stage-test.yml | |||
| - template: stage-aarch64.yml | |||
There was a problem hiding this comment.
this should probably go to deploy.yml
There was a problem hiding this comment.
@webknjaz Sorry for the confusion. stage-aarch64.yml was for running pytest for aarch64, same as stage-test.yml is for x86, Mac and Windows.. I have removed the stage-aarch64.yml file and added the changes in stage-test.yml itself. I have also added build steps to deploy.yml.
.azure-pipelines/stage-aarch64.yml
Outdated
| @@ -0,0 +1,45 @@ | |||
| stages: | |||
There was a problem hiding this comment.
this should go to https://github.com/aio-libs/azure-pipelines
There was a problem hiding this comment.
As mentioned above stage-aarch64.yml was for running pytest for aarch64, same as stage-test.yml is for x86, Mac and Windows.
Now I have removed the file and added in stage-test.yml file.
| @@ -0,0 +1,70 @@ | |||
| echo "exporting Mutlidict root directory" | |||
There was a problem hiding this comment.
this should probably go to https://github.com/aio-libs/azure-pipelines too
There was a problem hiding this comment.
I have removed the script and accumulated all the changes in stage-test.yml itself.
There was a problem hiding this comment.
This doesn't change the need to have it in a shared repo rather than copy-pasted all around the place.
|
I agree with @webknjaz BTW, looks like composite actions (https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action) can be used as a functional replacement for azure templates if we move to github workflows eventually. |
|
Oh, nice, I haven't heard of the composite actions yet! |
|
On my job I'm currently working with workflows a lot; recently learned about composite actions by accident. |
odidev
force-pushed
the
odidev_multidict
branch
3 times, most recently
from
85ef572
to
c88beca
Compare
There was a problem hiding this comment.
As per earlier comments, this should be implemented in the shared templates @ https://github.com/aio-libs/azure-pipelines and only referred from here.
odidev
force-pushed
the
odidev_multidict
branch
from
c88beca
to
daddbe8
Compare
odidev
force-pushed
the
odidev_multidict
branch
from
daddbe8
to
5c37e0a
Compare
|
@webknjaz Looks like odidev has followed up on your request: aio-libs/azure-pipelines#1 Tests are failing on this PR because the pipelines repo PR has not merged yet. Could you take a look at the pipeline change? |
|
Done by multidict 5.0.0 release Thanks for the PR, I've borrowed many implementation details from it while building my own version |
Added azure pipeline support for arm64 using qemu.
Related to issue number #500