Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log raw requests and responses when running availability check with debug flag #28645

Closed
2 tasks
girarda opened this issue Jul 24, 2023 · 1 comment · Fixed by #31368
Closed
2 tasks

Log raw requests and responses when running availability check with debug flag #28645

girarda opened this issue Jul 24, 2023 · 1 comment · Fixed by #31368
Assignees

Comments

@girarda
Copy link
Contributor

girarda commented Jul 24, 2023

What

The debug flag is used to log raw requests sent to an API source.

The requests sent as part of the stream availability check are not logged because we only apply the Source's log level to the Stream after the availability check.

Proposed solution

Apply the log level to the stream logger before we check if the stream is available (before line 116)

Acceptance criteria

  • Requests and responses from the availability check are logged when running with the debug flag
  • The connector builder either ignores these requests or shows them as auxiliary requests
@girarda
Copy link
Contributor Author

girarda commented Jul 25, 2023

grooming notes:

  • need to make sure the requests will actually be output by SimpleRetrieverTestReadDecorator
  • The requests and responses should show up in the connector builder as auxiliary requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants