bulk-cdk-toolkits-extract-cdc,source-mysql-v2: flesh out CDC #45887
+1,380
−1,700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
postamar
force-pushed
the
postamar/flesh-out-cdc
branch
3 times, most recently
from
7c76565
to
67073d3
Compare
postamar
changed the base branch from
master
to
postamar/bulk-cdk-fix-state-manager-bug
postamar
force-pushed
the
postamar/flesh-out-cdc
branch
2 times, most recently
from
bfb4312
to
fc53991
Compare
postamar
changed the title
Base automatically changed from
postamar/bulk-cdk-fix-state-manager-bug
to
master
September 25, 2024 20:44
postamar
force-pushed
the
postamar/flesh-out-cdc
branch
from
fc53991
to
16e6ad9
Compare
postamar
force-pushed
the
postamar/flesh-out-cdc
branch
from
16e6ad9
to
2b93470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fleshes out the Bulk CDK's CDC toolkit some more. Unit tests are missing. The level of polish here is lower than usual.
Fixes
https://github.com/airbytehq/airbyte-internal-issues/issues/9966
https://github.com/airbytehq/airbyte-internal-issues/issues/9893
https://github.com/airbytehq/airbyte-internal-issues/issues/9996
How
The main contributions here are:
DebeziumOperationsinterface. Implementations don't need to maintain any mutable state at all.MySqlDebeziumOperationsReview guide
The first commit just does class and file renames. The second commit has the actual changes. There's a lot of them. They're all in the WIP areas of the codebase.
User Impact
None
Can this PR be safely reverted and rolled back?