Merge pull request #34 from aizad-deriv/aizad/fix-mt5/account-card

Aizad / Fix CFD height css issue
aizad-deriv · Oct 31, 2022 · 4dd9673 · 4dd9673
2 parents 0f37276 + d1ada1a
commit 4dd9673
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/packages/cfd/src/Components/cfd-mt5-demo-account-display.tsx b/packages/cfd/src/Components/cfd-mt5-demo-account-display.tsx
@@ -107,7 +107,7 @@ const CFDMT5DemoAccountDisplay = ({
     }, [is_logged_in, is_eu, is_eu_country, residence, platform]);
 
     return (
-        <div className='cfd-demo-accounts-display' data-testid='dt_cfd_demo_accounts_display'>
+        <React.Fragment>
             {is_loading ? (
                 <Loading />
             ) : (
@@ -176,7 +176,7 @@ const CFDMT5DemoAccountDisplay = ({
                     )}
                 </div>
             )}
-        </div>
+        </React.Fragment>
     );
 };
 

diff --git a/packages/cfd/src/sass/cfd-dashboard.scss b/packages/cfd/src/sass/cfd-dashboard.scss
@@ -475,7 +475,7 @@
     grid-gap: 2.4rem;
     justify-content: center;
     padding-top: 2.4em;
-    height: 100%;
+    height: fit-content;
 
     @include mobile {
         display: flex;
@@ -486,12 +486,6 @@
     }
 }
 
-.cfd-demo-accounts-display .cfd-account-card__wrapper {
-    @include desktop {
-        height: auto;
-    }
-}
-
 .cfd-jurisdiction-card--synthetic,
 .cfd-jurisdiction-card--financial {
     border: solid 1px var(--border-normal);
@@ -733,11 +727,10 @@
         display: grid;
         grid-template-rows: 1fr;
         justify-content: center;
-        height: 100%;
+        height: fit-content;
 
         @include mobile {
             grid-template-rows: 1fr;
-            height: fit-content;
 
             &:not(:last-child) {
                 margin-bottom: 2.4rem;