fix: sonarcloud issue #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubega-deriv
requested review from
thisyahlen-deriv and
aizad-deriv
as code owners
aizad-deriv
approved these changes
Jan 18, 2024
aizad-deriv
merged commit d335c84
into
aizad/WALL-2807/create-reset-password-modal
0 of 2 checks passed
aizad-deriv
pushed a commit
that referenced
this pull request
Jun 14, 2024
…ary-com#15237) * refactor: [UPM-1080]/evgeniy/refactor passkeys code * refactor: tests and code completion * refactor: do not fetch passkeys list, when no need to open the modal * refactor: tests fix, remove btn loader status, icons change * refactor: do not call for passkeys if local storage value is false * chore: added todo for tracking events * refactor: client store remove unnecessary checks, tests, icons * chore: skip changing the state for created status * refactor: removed unnecessary li tag in modal * chore: rename passkey (#44) * chore: rename passkey * chore: test fix * fix: styles for rtl * refactor: call success event only after success renaming * chore: hide disabled dropdown item * chore: review comments * fix: accidentally removed clsx import * chore: snackbar fix, loading while fething new name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.