From 2579b48e867ebf2f64ab9daf6434fd9024c1a637 Mon Sep 17 00:00:00 2001
From: Akos Balasko <akos0215@gmail.com>
Date: Wed, 13 Mar 2024 09:50:35 +0100
Subject: [PATCH] feat: colors and custom fonts transformed to default markdown
 highlights (#619)

---
 Notes_for_Logseq.md                   |  2 +-
 README.md                             |  4 +-
 config.json                           |  2 +-
 config.logseq.json                    |  2 +-
 config.tana.json                      |  2 +-
 package-lock.json                     | 58 +++++++++------------------
 src/YarleOptions.ts                   |  2 +-
 src/ui/index.html                     |  4 +-
 src/ui/settingsMapper.ts              |  4 +-
 src/utils/turndown-rules/span-rule.ts | 11 +++--
 test/data/Colors.md                   | 28 ++++++-------
 test/data/charmapNotebookTest.enex    | 15 +++++++
 test/data/customfont.md               |  2 +-
 test/yarle-special-cases.spec.ts      |  4 +-
 14 files changed, 68 insertions(+), 72 deletions(-)
 create mode 100644 test/data/charmapNotebookTest.enex

diff --git a/Notes_for_Logseq.md b/Notes_for_Logseq.md
index 6d9aa3b8..c1eb3613 100644
--- a/Notes_for_Logseq.md
+++ b/Notes_for_Logseq.md
@@ -52,7 +52,7 @@ Please use settings below
   	"useUniqueUnknownFileNames": false,
     "useLevenshteinForLinks": false,
     "keepEvernoteLinkIfNoNoteFound": false,
-    "keepFontColors": false,
+    "convertColorsToMDHighlight": false,
     "logseqSettings":{
       "journalNotes": false
     }
diff --git a/README.md b/README.md
index 5c5423e4..8eef689b 100644
--- a/README.md
+++ b/README.md
@@ -179,7 +179,7 @@ To configure Yarle, you must create a config file. By default it looks like this
    "haveGlobalResources": false,
    "useUniqueUnknownFileNames": false,
    "useLevenshteinForLinks": false,
-   "keepFontColors": false,
+   "convertColorsToMDHighlight": false,
     "logseqSettings":{
         "journalNotes": false
     },
@@ -228,7 +228,7 @@ The following configurational properties are available:
 |```useUniqueUnknownFileNames``` | boolean | generates a couple of random characters at the end of the resource file names if the exact name cannot be recognised. For instance: unknown_filename-d2fd86c3.pdf
 |```useLevenshteinForLinks```| boolean| it applies the link to the note with the filename that has the closest Levenshtein distance to the text of the link
 |```keepEvernoteLinkIfNoNoteFound```| boolean | it keeps the link to the evernote note if no such note found among the converted files
-|```keepFontColors```| boolean | it keeps the custom font family and colors encoded as inline styles in span
+|```convertColorsToMDHighlight```| boolean | it converts colored highlights and custom font spans to standard markdown highlights
  
 Metadata settings can be set via the template.
 
diff --git a/config.json b/config.json
index eddbee0d..4ce85acc 100644
--- a/config.json
+++ b/config.json
@@ -34,7 +34,7 @@
     "useUniqueUnknownFileNames": false,
     "useLevenshteinForLinks": false,
     "keepEvernoteLinkIfNoNoteFound": false,
-    "keepFontColors": false,
+    "convertColorsToMDHighlight": false,
 
     "replacementChar": "_",
     "replacementCharacterMap": {
diff --git a/config.logseq.json b/config.logseq.json
index df0ca585..ef3e2355 100644
--- a/config.logseq.json
+++ b/config.logseq.json
@@ -67,7 +67,7 @@
 	"useUniqueUnknownFileNames": false,
     "useLevenshteinForLinks": false,
     "keepEvernoteLinkIfNoNoteFound": false,
-    "keepFontColors": false,
+    "convertColorsToMDHighlight": false,
     "logseqSettings":{
         "journalNotes": false
     },
diff --git a/config.tana.json b/config.tana.json
index 772b975d..88f75a86 100644
--- a/config.tana.json
+++ b/config.tana.json
@@ -34,7 +34,7 @@
     "useUniqueUnknownFileNames": false,
     "useLevenshteinForLinks": false,
     "keepEvernoteLinkIfNoNoteFound": false,
-    "keepFontColors": false,
+    "convertColorsToMDHighlight": false,
     "replacementChar": "_",
     "replacementCharacterMap": {
         "<": "_",
diff --git a/package-lock.json b/package-lock.json
index e922d3b8..b44bcc82 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1822,7 +1822,6 @@
       "version": "2.10.0",
       "resolved": "https://registry.npmjs.org/@types/yauzl/-/yauzl-2.10.0.tgz",
       "integrity": "sha512-Cn6WYCm0tXv8p6k+A8PvbDG763EDpBoTzHdA+Q/MF6H3sapGjCm9NzoaJncJS9tUKSuCoDs9XHxYYsQDgxR6kw==",
-      "dev": true,
       "optional": true,
       "dependencies": {
         "@types/node": "*"
@@ -2684,7 +2683,6 @@
       "version": "3.2.0",
       "resolved": "https://registry.npmjs.org/boolean/-/boolean-3.2.0.tgz",
       "integrity": "sha512-d0II/GO9uf9lfUHH2BQsjxzRJZBdsjgsBiW4BvhWk/3qoKwQFjIDVN19PfX8F2D/r9PCMTtLWjYVCFrpeYUzsw==",
-      "dev": true,
       "optional": true
     },
     "node_modules/bottleneck": {
@@ -4472,7 +4470,7 @@
       "version": "1.1.4",
       "resolved": "https://registry.npmjs.org/define-properties/-/define-properties-1.1.4.tgz",
       "integrity": "sha512-uckOqKcfaVvtBdsVkdPv3XjveQJsNQqmhXgRi8uhvWWuPYZCNlzT8qAyblUgNoXdHdjMTzAqeGjAoli8f+bzPA==",
-      "dev": true,
+      "devOptional": true,
       "dependencies": {
         "has-property-descriptors": "^1.0.0",
         "object-keys": "^1.1.1"
@@ -4561,7 +4559,6 @@
       "version": "2.1.0",
       "resolved": "https://registry.npmjs.org/detect-node/-/detect-node-2.1.0.tgz",
       "integrity": "sha512-T0NIuQpnTvFDATNuHN5roPwSBG83rFsuO+MXXH9/3N1eFbn4wcPjttvjMLEPWJ0RGUYgQE7cGgS3tNxbqCGM7g==",
-      "dev": true,
       "optional": true
     },
     "node_modules/diff": {
@@ -5419,7 +5416,7 @@
       "version": "4.1.1",
       "resolved": "https://registry.npmjs.org/es6-error/-/es6-error-4.1.1.tgz",
       "integrity": "sha512-Um/+FxMr9CISWh0bi5Zv0iOD+4cFh5qLeks1qhAopKVAJw3drgKbKySikp7wGhDL0HPeaja0P5ULZrxLkniUVg==",
-      "dev": true
+      "devOptional": true
     },
     "node_modules/escalade": {
       "version": "3.1.1",
@@ -6619,7 +6616,7 @@
       "version": "1.2.0",
       "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.2.0.tgz",
       "integrity": "sha512-L049y6nFOuom5wGyRc3/gdTLO94dySVKRACj1RmJZBQXlbTMhtNIgkWkUHq+jYmZvKf14EW1EoJnnjbmoHij0Q==",
-      "dev": true,
+      "devOptional": true,
       "dependencies": {
         "function-bind": "^1.1.1",
         "has": "^1.0.3",
@@ -6732,7 +6729,6 @@
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/global-agent/-/global-agent-3.0.0.tgz",
       "integrity": "sha512-PT6XReJ+D07JvGoxQMkT6qji/jVNfX/h364XHZOWeRzy64sSFr+xJ5OX7LI3b4MPQzdL4H8Y8M0xzPpsVMwA8Q==",
-      "dev": true,
       "optional": true,
       "dependencies": {
         "boolean": "^3.0.1",
@@ -6801,7 +6797,7 @@
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/globalthis/-/globalthis-1.0.3.tgz",
       "integrity": "sha512-sFdI5LyBiNTHjRd7cGPWapiHWMOXKyuBNX/cWJ3NfzrZQVa8GI/8cofCl74AOVqq9W5kNmguTIzJ/1s2gyI9wA==",
-      "dev": true,
+      "devOptional": true,
       "dependencies": {
         "define-properties": "^1.1.3"
       },
@@ -6988,7 +6984,7 @@
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/has-property-descriptors/-/has-property-descriptors-1.0.0.tgz",
       "integrity": "sha512-62DVLZGoiEBDHQyqG4w9xCuZ7eJEwNmJRWw2VY84Oedb7WFcA27fiEVe8oUQx9hAUJ4ekurquucTGwsyO1XGdQ==",
-      "dev": true,
+      "devOptional": true,
       "dependencies": {
         "get-intrinsic": "^1.1.1"
       },
@@ -7012,7 +7008,7 @@
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/has-symbols/-/has-symbols-1.0.3.tgz",
       "integrity": "sha512-l3LCuF6MgDNwTDKkdYGEihYjt5pRPbEg46rtlmnSPlUbgmB8LOIrKJbYYFBSbnPaJexMKtiPO8hmeRjRz2Td+A==",
-      "dev": true,
+      "devOptional": true,
       "engines": {
         "node": ">= 0.4"
       },
@@ -8161,7 +8157,7 @@
       "version": "5.0.1",
       "resolved": "https://registry.npmjs.org/json-stringify-safe/-/json-stringify-safe-5.0.1.tgz",
       "integrity": "sha512-ZClg6AaYvamvYEE82d3Iyd3vSSIjQ+odgjaTzRuO3s7toCdFKczob2i0zCh7JE8kWn17yvAWhUVxvqGwUalsRA==",
-      "dev": true
+      "devOptional": true
     },
     "node_modules/json5": {
       "version": "2.2.3",
@@ -8691,7 +8687,6 @@
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/matcher/-/matcher-3.0.0.tgz",
       "integrity": "sha512-OkeDaAZ/bQCxeFAozM55PKcKU0yJMPGifLwV4Qgjitu+5MoAfSQN4lsLJeXZ1b8w0x+/Emda6MZgXS1jvsapng==",
-      "dev": true,
       "optional": true,
       "dependencies": {
         "escape-string-regexp": "^4.0.0"
@@ -8704,7 +8699,6 @@
       "version": "4.0.0",
       "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz",
       "integrity": "sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==",
-      "dev": true,
       "optional": true,
       "engines": {
         "node": ">=10"
@@ -13029,7 +13023,7 @@
       "version": "1.1.1",
       "resolved": "https://registry.npmjs.org/object-keys/-/object-keys-1.1.1.tgz",
       "integrity": "sha512-NuAESUOUMrlIXOfHKzD6bpPu3tYt3xvjNdRIQ+FeT0lNb4K8WR70CaDxhuNguS2XG+GjkyMwOzsN5ZktImfhLA==",
-      "dev": true,
+      "devOptional": true,
       "engines": {
         "node": ">= 0.4"
       }
@@ -14291,7 +14285,6 @@
       "version": "2.15.4",
       "resolved": "https://registry.npmjs.org/roarr/-/roarr-2.15.4.tgz",
       "integrity": "sha512-CHhPh+UNHD2GTXNYhPWLnU8ONHdI+5DI+4EYIAOaiD63rHeYlZvyh8P+in5999TTSFgUYuKUAjzRI4mdh/p+2A==",
-      "dev": true,
       "optional": true,
       "dependencies": {
         "boolean": "^3.0.1",
@@ -14629,7 +14622,6 @@
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/semver-compare/-/semver-compare-1.0.0.tgz",
       "integrity": "sha512-YM3/ITh2MJ5MtzaM429anh+x2jiLVjqILF4m4oyQB18W7Ggea7BfqdH/wGMK7dDiMghv/6WG7znWMwUDzJiXow==",
-      "dev": true,
       "optional": true
     },
     "node_modules/semver-diff": {
@@ -14669,7 +14661,6 @@
       "version": "7.0.1",
       "resolved": "https://registry.npmjs.org/serialize-error/-/serialize-error-7.0.1.tgz",
       "integrity": "sha512-8I8TjW5KMOKsZQTvoxjuSIa7foAwPWGOts+6o7sgjz41/qMD9VQHEDxi6PBvK2l0MXUmqZyNpUK+T2tQaaElvw==",
-      "dev": true,
       "optional": true,
       "dependencies": {
         "type-fest": "^0.13.1"
@@ -14685,7 +14676,6 @@
       "version": "0.13.1",
       "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.13.1.tgz",
       "integrity": "sha512-34R7HTnG0XIJcBSn5XhDd7nNFPRcXYRZrBB2O2jdKqYODldSzBAqzsWoZYYvduky73toYS/ESqxPvkDf/F0XMg==",
-      "dev": true,
       "optional": true,
       "engines": {
         "node": ">=10"
@@ -14954,6 +14944,7 @@
       "version": "0.6.1",
       "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz",
       "integrity": "sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==",
+      "devOptional": true,
       "engines": {
         "node": ">=0.10.0"
       }
@@ -15048,7 +15039,6 @@
       "version": "1.1.2",
       "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.1.2.tgz",
       "integrity": "sha512-VE0SOVEHCk7Qc8ulkWw3ntAzXuqf7S2lvwQaDLRnUeIEaKNQJzV6BwmLKhOqT61aGhfUMrXeaBk+oDGCzvhcug==",
-      "dev": true,
       "optional": true
     },
     "node_modules/ssri": {
@@ -18275,7 +18265,6 @@
       "version": "2.10.0",
       "resolved": "https://registry.npmjs.org/@types/yauzl/-/yauzl-2.10.0.tgz",
       "integrity": "sha512-Cn6WYCm0tXv8p6k+A8PvbDG763EDpBoTzHdA+Q/MF6H3sapGjCm9NzoaJncJS9tUKSuCoDs9XHxYYsQDgxR6kw==",
-      "dev": true,
       "optional": true,
       "requires": {
         "@types/node": "*"
@@ -18900,7 +18889,6 @@
       "version": "3.2.0",
       "resolved": "https://registry.npmjs.org/boolean/-/boolean-3.2.0.tgz",
       "integrity": "sha512-d0II/GO9uf9lfUHH2BQsjxzRJZBdsjgsBiW4BvhWk/3qoKwQFjIDVN19PfX8F2D/r9PCMTtLWjYVCFrpeYUzsw==",
-      "dev": true,
       "optional": true
     },
     "bottleneck": {
@@ -20245,7 +20233,7 @@
       "version": "1.1.4",
       "resolved": "https://registry.npmjs.org/define-properties/-/define-properties-1.1.4.tgz",
       "integrity": "sha512-uckOqKcfaVvtBdsVkdPv3XjveQJsNQqmhXgRi8uhvWWuPYZCNlzT8qAyblUgNoXdHdjMTzAqeGjAoli8f+bzPA==",
-      "dev": true,
+      "devOptional": true,
       "requires": {
         "has-property-descriptors": "^1.0.0",
         "object-keys": "^1.1.1"
@@ -20309,7 +20297,6 @@
       "version": "2.1.0",
       "resolved": "https://registry.npmjs.org/detect-node/-/detect-node-2.1.0.tgz",
       "integrity": "sha512-T0NIuQpnTvFDATNuHN5roPwSBG83rFsuO+MXXH9/3N1eFbn4wcPjttvjMLEPWJ0RGUYgQE7cGgS3tNxbqCGM7g==",
-      "dev": true,
       "optional": true
     },
     "diff": {
@@ -20996,7 +20983,7 @@
       "version": "4.1.1",
       "resolved": "https://registry.npmjs.org/es6-error/-/es6-error-4.1.1.tgz",
       "integrity": "sha512-Um/+FxMr9CISWh0bi5Zv0iOD+4cFh5qLeks1qhAopKVAJw3drgKbKySikp7wGhDL0HPeaja0P5ULZrxLkniUVg==",
-      "dev": true
+      "devOptional": true
     },
     "escalade": {
       "version": "3.1.1",
@@ -21913,7 +21900,7 @@
       "version": "1.2.0",
       "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.2.0.tgz",
       "integrity": "sha512-L049y6nFOuom5wGyRc3/gdTLO94dySVKRACj1RmJZBQXlbTMhtNIgkWkUHq+jYmZvKf14EW1EoJnnjbmoHij0Q==",
-      "dev": true,
+      "devOptional": true,
       "requires": {
         "function-bind": "^1.1.1",
         "has": "^1.0.3",
@@ -21998,7 +21985,6 @@
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/global-agent/-/global-agent-3.0.0.tgz",
       "integrity": "sha512-PT6XReJ+D07JvGoxQMkT6qji/jVNfX/h364XHZOWeRzy64sSFr+xJ5OX7LI3b4MPQzdL4H8Y8M0xzPpsVMwA8Q==",
-      "dev": true,
       "optional": true,
       "requires": {
         "boolean": "^3.0.1",
@@ -22047,7 +22033,7 @@
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/globalthis/-/globalthis-1.0.3.tgz",
       "integrity": "sha512-sFdI5LyBiNTHjRd7cGPWapiHWMOXKyuBNX/cWJ3NfzrZQVa8GI/8cofCl74AOVqq9W5kNmguTIzJ/1s2gyI9wA==",
-      "dev": true,
+      "devOptional": true,
       "requires": {
         "define-properties": "^1.1.3"
       }
@@ -22183,7 +22169,7 @@
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/has-property-descriptors/-/has-property-descriptors-1.0.0.tgz",
       "integrity": "sha512-62DVLZGoiEBDHQyqG4w9xCuZ7eJEwNmJRWw2VY84Oedb7WFcA27fiEVe8oUQx9hAUJ4ekurquucTGwsyO1XGdQ==",
-      "dev": true,
+      "devOptional": true,
       "requires": {
         "get-intrinsic": "^1.1.1"
       }
@@ -22198,7 +22184,7 @@
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/has-symbols/-/has-symbols-1.0.3.tgz",
       "integrity": "sha512-l3LCuF6MgDNwTDKkdYGEihYjt5pRPbEg46rtlmnSPlUbgmB8LOIrKJbYYFBSbnPaJexMKtiPO8hmeRjRz2Td+A==",
-      "dev": true
+      "devOptional": true
     },
     "has-tostringtag": {
       "version": "1.0.0",
@@ -23031,7 +23017,7 @@
       "version": "5.0.1",
       "resolved": "https://registry.npmjs.org/json-stringify-safe/-/json-stringify-safe-5.0.1.tgz",
       "integrity": "sha512-ZClg6AaYvamvYEE82d3Iyd3vSSIjQ+odgjaTzRuO3s7toCdFKczob2i0zCh7JE8kWn17yvAWhUVxvqGwUalsRA==",
-      "dev": true
+      "devOptional": true
     },
     "json5": {
       "version": "2.2.3",
@@ -23462,7 +23448,6 @@
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/matcher/-/matcher-3.0.0.tgz",
       "integrity": "sha512-OkeDaAZ/bQCxeFAozM55PKcKU0yJMPGifLwV4Qgjitu+5MoAfSQN4lsLJeXZ1b8w0x+/Emda6MZgXS1jvsapng==",
-      "dev": true,
       "optional": true,
       "requires": {
         "escape-string-regexp": "^4.0.0"
@@ -23472,7 +23457,6 @@
           "version": "4.0.0",
           "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz",
           "integrity": "sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==",
-          "dev": true,
           "optional": true
         }
       }
@@ -26602,7 +26586,7 @@
       "version": "1.1.1",
       "resolved": "https://registry.npmjs.org/object-keys/-/object-keys-1.1.1.tgz",
       "integrity": "sha512-NuAESUOUMrlIXOfHKzD6bpPu3tYt3xvjNdRIQ+FeT0lNb4K8WR70CaDxhuNguS2XG+GjkyMwOzsN5ZktImfhLA==",
-      "dev": true
+      "devOptional": true
     },
     "object.assign": {
       "version": "4.1.4",
@@ -27551,7 +27535,6 @@
       "version": "2.15.4",
       "resolved": "https://registry.npmjs.org/roarr/-/roarr-2.15.4.tgz",
       "integrity": "sha512-CHhPh+UNHD2GTXNYhPWLnU8ONHdI+5DI+4EYIAOaiD63rHeYlZvyh8P+in5999TTSFgUYuKUAjzRI4mdh/p+2A==",
-      "dev": true,
       "optional": true,
       "requires": {
         "boolean": "^3.0.1",
@@ -27798,7 +27781,6 @@
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/semver-compare/-/semver-compare-1.0.0.tgz",
       "integrity": "sha512-YM3/ITh2MJ5MtzaM429anh+x2jiLVjqILF4m4oyQB18W7Ggea7BfqdH/wGMK7dDiMghv/6WG7znWMwUDzJiXow==",
-      "dev": true,
       "optional": true
     },
     "semver-diff": {
@@ -27828,7 +27810,6 @@
       "version": "7.0.1",
       "resolved": "https://registry.npmjs.org/serialize-error/-/serialize-error-7.0.1.tgz",
       "integrity": "sha512-8I8TjW5KMOKsZQTvoxjuSIa7foAwPWGOts+6o7sgjz41/qMD9VQHEDxi6PBvK2l0MXUmqZyNpUK+T2tQaaElvw==",
-      "dev": true,
       "optional": true,
       "requires": {
         "type-fest": "^0.13.1"
@@ -27838,7 +27819,6 @@
           "version": "0.13.1",
           "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.13.1.tgz",
           "integrity": "sha512-34R7HTnG0XIJcBSn5XhDd7nNFPRcXYRZrBB2O2jdKqYODldSzBAqzsWoZYYvduky73toYS/ESqxPvkDf/F0XMg==",
-          "dev": true,
           "optional": true
         }
       }
@@ -28046,7 +28026,8 @@
     "source-map": {
       "version": "0.6.1",
       "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz",
-      "integrity": "sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g=="
+      "integrity": "sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==",
+      "devOptional": true
     },
     "source-map-support": {
       "version": "0.5.21",
@@ -28132,7 +28113,6 @@
       "version": "1.1.2",
       "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.1.2.tgz",
       "integrity": "sha512-VE0SOVEHCk7Qc8ulkWw3ntAzXuqf7S2lvwQaDLRnUeIEaKNQJzV6BwmLKhOqT61aGhfUMrXeaBk+oDGCzvhcug==",
-      "dev": true,
       "optional": true
     },
     "ssri": {
diff --git a/src/YarleOptions.ts b/src/YarleOptions.ts
index 14ca23dd..54ac70cb 100644
--- a/src/YarleOptions.ts
+++ b/src/YarleOptions.ts
@@ -61,6 +61,6 @@ export interface YarleOptions {
     useUniqueUnknownFileNames?: boolean;
     useLevenshteinForLinks?: boolean;
     keepEvernoteLinkIfNoNoteFound?: boolean;
-    keepFontColors?: boolean;
+    convertColorsToMDHighlight?: boolean;
     globalReplacementSettings?: Array<SearchAndReplace>;
 }
diff --git a/src/ui/index.html b/src/ui/index.html
index 38346cf7..82b52e60 100644
--- a/src/ui/index.html
+++ b/src/ui/index.html
@@ -368,11 +368,11 @@ <h5 class="info-text">General </h5>
 												</div>
 													<div class="form-group">
 														<!--<input type="checkbox" value="false" id='addExtensionToInternalLinks'> -->
-											<label for="keepFontColors" class="pure-checkbox">
+											<label for="convertColorsToMDHighlight" class="pure-checkbox">
 											Keeps custom font family and font colors encoded as inline style in span
 											<br><div style='font-size: 12px;'><i>Please note that this feature keeps spans as html tags, so it won't produce a standard Markdown file</i></div>
 											</label>
-											<select class="form-control configurationItem" name="keepFontColors" id="keepFontColors">
+											<select class="form-control configurationItem" name="convertColorsToMDHighlight" id="convertColorsToMDHighlight">
 												<option value="true">Yes</option>
 												<option value="false" selected>No</option>
 											</select>
diff --git a/src/ui/settingsMapper.ts b/src/ui/settingsMapper.ts
index b4d36746..29fff298 100644
--- a/src/ui/settingsMapper.ts
+++ b/src/ui/settingsMapper.ts
@@ -12,8 +12,10 @@ enum DefaultRootType {
 }
 const loadJSONSafely = (jsonString: string, defaultRootTyoe: DefaultRootType): any => {
     try {
+        console.log(jsonString);
         return JSON.parse(jsonString);
     }catch(e){
+        console.log("ERROR", e);
         return defaultRootTyoe === DefaultRootType.array
             ? []
             : {}
@@ -69,7 +71,7 @@ export const mapSettingsToYarleOptions = (): YarleOptions => {
         haveGlobalResources: store.get('haveGlobalResources') as boolean,
         useUniqueUnknownFileNames: store.get('useUniqueUnknownFileNames') as boolean,
         useLevenshteinForLinks: store.get('useLevenshteinForLinks') as boolean,
-        keepFontColors: store.get('keepFontColors') as boolean,
+        convertColorsToMDHighlight: store.get('convertColorsToMDHighlight') as boolean,
         keepEvernoteLinkIfNoNoteFound: store.get('keepEvernoteLinkIfNoNoteFound') as boolean,
         sanitizeResourceNameSpaces: store.get('sanitizeResourceNameSpaces') as boolean,
         replacementChar: store.get('replacementChar') as string,
diff --git a/src/utils/turndown-rules/span-rule.ts b/src/utils/turndown-rules/span-rule.ts
index ab060925..6ac98bb3 100644
--- a/src/utils/turndown-rules/span-rule.ts
+++ b/src/utils/turndown-rules/span-rule.ts
@@ -29,12 +29,11 @@ export const spanRule = {
                 if (!hasBold && hasItalic) { return `${languageItems.italic}${content}${languageItems.italic}`; }
                 if (hasBold && hasItalic) { return `${languageItems.italic}${languageItems.bold}${content}${languageItems.bold}${languageItems.italic}`; }
             }
-            if (yarleOptions.keepFontColors){
-                const match = nodeValue.match(/color:rgb\(\d{0,3}, \d{0,3}, \d{0,3}\);|background-color: #([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})|--en-fontfamily:[^"]*|font-size:[^"]*/)
-                if (match)
-                    content =  `<span style="${match[0]}">${content}</span>`
-            }
-            return nodeValue.includes(EVERNOTE_HIGHLIGHT) || nodeValue.includes(EVERNOTE_COLORHIGHLIGHT) ?
+            const match = nodeValue.match(/color:rgb\(\d{0,3}, \d{0,3}, \d{0,3}\);|background-color: #([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})|--en-fontfamily:[^"]*/)
+
+            return nodeValue.includes(EVERNOTE_HIGHLIGHT) ||
+                nodeValue.includes(EVERNOTE_COLORHIGHLIGHT) ||
+                (yarleOptions.convertColorsToMDHighlight && match)?
                 `${languageItems.highlight}${content}${languageItems.highlight}` :
                 content;
         }
diff --git a/test/data/Colors.md b/test/data/Colors.md
index dab0b1cc..53f11798 100644
--- a/test/data/Colors.md
+++ b/test/data/Colors.md
@@ -1,34 +1,34 @@
 # Colors
 
 Normal line
-<span style="color:rgb(252, 18, 51);">Red line</span>
-<span style="color:rgb(229, 158, 37);">Yellow line</span>
-<span style="color:rgb(24, 133, 226);">Blue line</span>
-<span style="color:rgb(24, 168, 65);">Green line</span>
-==<span style="background-color: #ffef9e"><span style="color:rgb(51, 51, 51);">Yellow Highlighted line</span></span>==
-==<span style="background-color: #fec1d0"><span style="color:rgb(51, 51, 51);">Red Highlighted line</span></span>==
-==<span style="background-color: #fec1d0"><span style="color:rgb(252, 18, 51);">Red highlighed red line</span></span>==
+==Red line==
+==Yellow line==
+==Blue line==
+==Green line==
+====Yellow Highlighted line====
+====Red Highlighted line====
+====Red highlighed red line====
 
 BOLD
-**==<span style="background-color: #fec1d0"><span style="color:rgb(252, 18, 51);">Red highlighed red line</span></span>==**
+**====Red highlighed red line====**
 ITALIC
-==<span style="background-color: #fec1d0">_<span style="color:rgb(252, 18, 51);">Red highlighed red line</span>_</span>==
+==_==Red highlighed red line==_==
 UNDERSCORE
-==<span style="background-color: #fec1d0"><span style="color:rgb(252, 18, 51);"><u>Red highlighed red line</u></span></span>==
+====<u>Red highlighed red line</u>====
 Large header
 
-# ==<span style="background-color: #fec1d0">Red highlighed red line</span>==
+# ==Red highlighed red line==
 
 Medium header
 
-## ==<span style="background-color: #fec1d0">Red highlighed red line</span>==
+## ==Red highlighed red line==
 
 Small header
 
-### ==<span style="background-color: #fec1d0">Red highlighed red line</span>==
+### ==Red highlighed red line==
 
 Custom font
-<span style="--en-fontfamily: monospace; font-family: "><span style="font-size: 14px;">==<span style="background-color: #fec1d0"><span style="color:rgb(252, 18, 51);">Red highlighed red line</span></span>==</span></span>
+======Red highlighed red line======
 
     Created at: 2024-02-06T07:09:48+00:00
     Updated at: 2024-02-06T18:20:07+00:00
diff --git a/test/data/charmapNotebookTest.enex b/test/data/charmapNotebookTest.enex
new file mode 100644
index 00000000..2db7a2a5
--- /dev/null
+++ b/test/data/charmapNotebookTest.enex
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE en-export SYSTEM "http://xml.evernote.com/pub/evernote-export4.dtd">
+<en-export export-date="20240309T065929Z" application="Evernote" version="10.78.2">
+  <note>
+    <title>charmap|#^@ globalRegex[@][#]</title>
+    <created>20240309T065602Z</created>
+    <updated>20240309T065840Z</updated>
+    <note-attributes>
+    </note-attributes>
+    <content>
+      <![CDATA[<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE en-note SYSTEM "http://xml.evernote.com/pub/enml2.dtd"><en-note><div>Charactermap:</div><div><br/></div><div><span style="color:rgb(34, 34, 34);">{</span></div><div><span style="color:rgb(34, 34, 34);">  "|": "--",</span></div><div><span style="color:rgb(34, 34, 34);">  "#": "*",</span></div><div><span style="color:rgb(80, 0, 80);">  "^": "*",</span></div><div><span style="color:rgb(80, 0, 80);">  "@": "!",</span></div><div><span style="color:rgb(80, 0, 80);">}</span></div><div><span style="color:rgb(80, 0, 80);"><span style="--en-markholder:true;"><br/></span></span></div><div><span style="color:rgb(80, 0, 80);">Global Regexp on title: </span></div><div><span style="color:rgb(80, 0, 80);">{</span></div><div><span style="color:rgb(80, 0, 80);">    "type": "title",</span></div><div><span style="color:rgb(80, 0, 80);">    "regex": "[@]",</span></div><div><span style="color:rgb(80, 0, 80);">    "replace": "!"</span></div><div><span style="color:rgb(80, 0, 80);">  },</span></div><div><br/></div><div><span style="color:rgb(80, 0, 80);">  {</span></div><div><span style="color:rgb(80, 0, 80);">    "type": "title",</span></div><div><span style="color:rgb(80, 0, 80);">    "regex": "[#]",</span></div><div><span style="color:rgb(80, 0, 80);">    "replace": "\*"</span></div><div><span style="color:rgb(80, 0, 80);">  },</span></div><div><br/></div></en-note>      ]]>
+    </content>
+  </note>
+</en-export>
diff --git a/test/data/customfont.md b/test/data/customfont.md
index 7290460f..15b0b37a 100644
--- a/test/data/customfont.md
+++ b/test/data/customfont.md
@@ -1,6 +1,6 @@
 # customfont
 
-<span style="--en-fontfamily: handwritten; font-family: Kalam,cursive,handwritten">Keeping the custom <span style="font-size: 20px;">font</span> <span style="color:rgb(251, 95, 44);">and</span> **_<u>everything</u>_**</span>
+==Keeping the custom font ==and== **_<u>everything</u>_**==
 
     Created at: 2024-02-11T21:40:58+00:00
     Updated at: 2024-02-11T22:07:12+00:00
diff --git a/test/yarle-special-cases.spec.ts b/test/yarle-special-cases.spec.ts
index af9a598c..a7104b6d 100644
--- a/test/yarle-special-cases.spec.ts
+++ b/test/yarle-special-cases.spec.ts
@@ -633,7 +633,7 @@ dateFormat: undefined,
       enexSources: [ `${testDataFolder}Colors.enex` ],
       outputDir: 'out',
       isMetadataNeeded: true,
-      keepFontColors: true,
+      convertColorsToMDHighlight: true,
       plainTextNotesOnly: false,
       outputFormat: OutputFormat.ObsidianMD,
       keepMDCharactersOfENNotes: false,
@@ -661,7 +661,7 @@ dateFormat: undefined,
       enexSources: [ `${testDataFolder}customfont.enex` ],
       outputDir: 'out',
       isMetadataNeeded: true,
-      keepFontColors: true,
+      convertColorsToMDHighlight: true,
       plainTextNotesOnly: false,
       outputFormat: OutputFormat.ObsidianMD,
       keepMDCharactersOfENNotes: false,