fix: propagate duplex transform sink errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sink errors were either getting smothered or causing unhandled promise rejections depending on your platform. Instead if the sink of a duplex stream being used as a transform returns a promise, propagate errors thrown by the sink into it's source so they can be caught and handled by the consumer.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 268 303 +35
Branches 42 49 +7
=========================================
+ Hits 268 303 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2022
### [2.0.2](v2.0.1...v2.0.2) (2022-01-13) ### Bug Fixes * propagate duplex transform sink errors ([#8](#8)) ([89df9be](89df9be))
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
to alanshaw/abortable-iterator
that referenced
this pull request
Jan 13, 2022
Fix in it-pipe lets us abort duplex streams used as transforms. Refs: alanshaw/it-pipe#8
achingbrain
added a commit
to alanshaw/abortable-iterator
that referenced
this pull request
Jan 13, 2022
Fix in it-pipe lets us abort duplex streams used as transforms. Refs: alanshaw/it-pipe#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sink errors were either getting smothered or causing unhandled promise rejections depending on your platform.
This breaks on Chrome when creating an abortable-iterator from a duplex transform stream that you then try to abort.
Instead if the sink of a duplex stream being used as a transform returns a promise, propagate errors thrown by the sink into it's source so they can be caught and handled by the consumer.