Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineHighlight style is incorrect #910

Closed
1 task done
jmooring opened this issue Jan 6, 2024 · 5 comments
Closed
1 task done

LineHighlight style is incorrect #910

jmooring opened this issue Jan 6, 2024 · 5 comments
Labels

Comments

@jmooring
Copy link
Contributor

jmooring commented Jan 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

There are currently 5 styles that specify LineHighlight:

In each case, the resulting style is #HEXCODE instead of bg: #HEXCODE.

cc: @icy-comet

To Reproduce

Not applicable because the playground does not allow you to specify which lines to highlight.

@alecthomas
Copy link
Owner

Contributions are welcome.

@jmooring
Copy link
Contributor Author

jmooring commented Jan 6, 2024

@alecthomas Understood. My understanding is that these styles are generated, not hand coded. I don't spend enough time in the codebase to know where to start. I cc'd icy-comet because it looks like they were the last one to touch all five styles.

@alecthomas
Copy link
Owner

They're not generated, they're XML files in this directory: https://github.com/alecthomas/chroma/tree/master/styles

@jmooring
Copy link
Contributor Author

jmooring commented Jan 6, 2024

#797 (comment)

These definitions have been dynamically created using a script to keep up with changes in the color pallete.

I'd hate to make changes just to have them overwritten the next time someone uses the script referenced above.

@icy-comet
Copy link
Contributor

the script referenced above

It's an external script I use to keep the styles up-to-date with the upstream color definitions and is entirely independent of chroma.

Anyways, I have updated the template in my repo and also opened a PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants