Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSV lexer #1005

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add CSV lexer #1005

wants to merge 9 commits into from
+72 −0

Commits on Sep 28, 2024

  1. Add initial CSV test case 

    To be updated once we have a lexer in place.
    @walles
    walles committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0214e2b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Make a better test case 

    I believe this test case contains all corner cases from the spec.
    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9c40824 View commit details
    Browse the repository at this point in the history

  2. Include an error case in the test case

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c3312c8 View commit details
    Browse the repository at this point in the history

  3. Try handling double quotes

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    198668d View commit details
    Browse the repository at this point in the history

  4. Tune expectation 

    Both by fixing the indentation to make the test suite happy and by
adding LiteralStringEscape to the expected output.
    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    35a4d77 View commit details
    Browse the repository at this point in the history

  5. Fix escaped comma handling

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    06b823b View commit details
    Browse the repository at this point in the history

  6. Reality check, this is easier

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4c32da9 View commit details
    Browse the repository at this point in the history

  7. Maybe this is coalesced somehow?

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    26c6f87 View commit details
    Browse the repository at this point in the history

  8. Improve docs

    @walles
    walles committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    833c9b0 View commit details
    Browse the repository at this point in the history