[ETH] Upgrade packer to EIP 1559 gas fees #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-eth-packer-eip1559
branch
from
0ba9703
to
cd55629
Compare
Fixed an issue where the pending message job would block on the final messages in the queue and stop processing newer messages. Once the job finishes the loop on all the messages in the pending message collection, the previous implementation waits until all the message tasks finish. This causes a delay of several hours until the node finishes these tasks and is able to process newer pending messages again. Messages end up being processed, but far later than expected. The issue arises because we never remove messages from the pending queue if we fail to retrieve the associated content. The job then always has messages in the queue, causing the issue. Fixed the issue by allowing the loop to restart without waiting for messages to be processed. We now compute an individual ID for each pending message and add it to a set. The job will simply ignore any message that is already being processed, allowing for newer messages to be taken into account.
Upgraded the packer task to use EIP 1559 fees instead of legacy fees. The task now specifies the `maxFeePerGas` parameter to specify the maximum allowed value for the base + priority fee. It also specifies a maximum priority fee of 2 gwei by default, as this seems to be a recommended value to get the transaction included by miners.
odesenfans
force-pushed
the
od-eth-packer-eip1559
branch
from
04d83e2
to
095f79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the packer task to use EIP 1559 fees instead of legacy
fees. The task now specifies the
maxFeePerGasparameter tospecify the maximum allowed value for the base + priority fee.
It also specifies a maximum priority fee of 2 gwei by default,
as this seems to be a recommended value to get the transaction
included by miners.